PERF: Fix quantile perf regression #35101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pandas-dev#35049 ```pyhon 591 µs ± 29.5 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each) 440 µs ± 22.8 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each) ```
jbrockmendel
reviewed
Jul 2, 2020
pandas/util/_validators.py
Outdated
| ) | ||
| # Don't change this to an f-string. The string formatting | ||
| # is too expensive for cases where we don't need it. | ||
| msg = "percentiles should all be in the interval [0, 1]." "Try {} instead." |
There was a problem hiding this comment.
extra quotation marks probably an artifact of black
|
Should we take a more general look at where we can/should do string formatting more lazily? |
|
Interesting - so the evaluation of q / 100 makes things slower right? I would have thought generally f-strings would be more performant given things like this: https://stackoverflow.com/questions/43123408/f-strings-in-python-3-6 But I suppose that assumes that the expression needs to be evaluated, which isn't the case here unless an exception occurs |
simonjayhawkins
added
Performance
|
Thanks @TomAugspurger |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35049