Skip to content

Performance regression in frame_methods.Quantile.time_frame_quantile #35049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jun 29, 2020 · 0 comments · Fixed by #35101
Closed

Performance regression in frame_methods.Quantile.time_frame_quantile #35049

TomAugspurger opened this issue Jun 29, 2020 · 0 comments · Fixed by #35101
Labels
Blocker Blocking issue or pull request for an upcoming release Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.1

Comments

@TomAugspurger
Copy link
Contributor

https://pandas.pydata.org/speed/pandas/index.html#frame_methods.Quantile.time_frame_quantile?p-axis=0&commits=ce292485c781ec0df0a765869848b97ac3c88a54

ce29248 (an f-string PR). Most likely the formatting is somewhat expensive.
@TomAugspurger TomAugspurger added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version Blocker Blocking issue or pull request for an upcoming release labels Jun 29, 2020
@TomAugspurger TomAugspurger added this to the 1.1 milestone Jun 29, 2020
TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Jul 2, 2020
@TomAugspurger
PERF: Fix quantile perf regression
b4ce575 
Closes pandas-dev#35049

```pyhon
591 µs ± 29.5 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

440 µs ± 22.8 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)
```
@TomAugspurger TomAugspurger mentioned this issue Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Blocking issue or pull request for an upcoming release Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

PERF: Fix quantile perf regression TomAugspurger/pandas
1 participant
@TomAugspurger