-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix numpy warning #35085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numpy warning #35085
Conversation
pandas/conftest.py
Outdated
@@ -257,7 +257,7 @@ def nselect_method(request): | |||
# Missing values & co. | |||
# ---------------------------------------------------------------- | |||
@pytest.fixture( | |||
params=[None, np.nan, pd.NaT, float("nan"), np.float("NaN"), pd.NA], ids=str | |||
params=[None, np.nan, pd.NaT, float("nan"), float("nan"), pd.NA], ids=str | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we want to float("nan")
s in here. maybe this should be np.float64("nan")
? best guess is the point of having this in addition to np.nan
is bc nan
is not a singleton like pd.NaT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is equivalent to what we had before, since np.float
was an alias for float
. You're saying that isn't what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just speculating; im pretty confident we dont want two identical objects in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I missed that we already had float('"nan")
.
Various failures like
which I can't look into at the moment. I'll just remove the duplicate key. |
No description provided.