REF: remove Block.concat_same_type #33486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 12, 2020
pandas/core/internals/concat.py
Outdated
| vals = [ju.block.values for ju in join_units] | ||
|
|
||
| if not blk.is_extension: | ||
| values = concat_compat(vals, axis=blk.ndim - 1) |
There was a problem hiding this comment.
hmm, doesn't concat_compat already handle this? why do you need cases here?
There was a problem hiding this comment.
why do you need cases here?
I hope you're sitting down because this may come as a shock: because EAs dont support 2D.
There was a problem hiding this comment.
i get that
but the cases are all the same
There was a problem hiding this comment.
The last one is not, we dont pass axis
There was a problem hiding this comment.
ok, but you still don't need line 70 at all
jreback
added
Dtype Conversions
jreback
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the relevant logic lives in concat_compat already.