REF: dispatch TDBlock.to_native_types to TDA._format_native_types #33270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 5, 2020
There was a problem hiding this comment.
this is changing the output format from the truncated (e.g. 1 days to, to the full, e.g. 1 days 00:00:00.000000).
I don't think that is actually desiriable as this affects the display in csv and in a series/dataframe.
I guess this is not really tested aside from the tests you changed.
We correctly handle this for datetimes, so must be some slightly differing path.
…ock-to_native_types-tdblock
|
If we don't want to change the DataFrame/to_csv behavior, we could add the "0 days" back in to the TDI/TDA behavior. That only requires changing 2 tests (both of which are directly testing Timedelta64Formatter) |
|
i think that would be better to add back to TDIFormatter |
|
updated |
…ock-to_native_types-tdblock
jreback
approved these changes
Apr 6, 2020
|
nice! |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 11, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.