CLN: Clean nanops.get_corr_func #33244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Apr 2, 2020
jbrockmendel
reviewed
Apr 4, 2020
| return np.corrcoef(a, b)[0, 1] | ||
|
|
||
| def _kendall(a, b): | ||
| # kendallttau returns a tuple of the tau statistic and pvalue |
There was a problem hiding this comment.
is this comment worth retaining?
There was a problem hiding this comment.
Might as well, should we also have a comment for spearmanr and np.corrcoef?
jreback
requested changes
Apr 5, 2020
| def func(a, b): | ||
| return kendalltau(a, b)[0] | ||
|
|
||
| return func |
There was a problem hiding this comment.
i would make all of these lambda, e.g.(for all 3 cases)
return lambda a, b: kendaltau(a, b)[0]
There was a problem hiding this comment.
hah, i asked for these to be changed from lambda to non-lambdas for nicer tracebacks
There was a problem hiding this comment.
oh really it does? hmm, ok, then that's fine
jreback
added
Clean
Numeric Operations
There's testing at least for DataFrame.corr (test_corr_invalid_method in /tests/frame/methods/test_cov_corr.py) but not this function directly AFAIK |
jreback
approved these changes
Apr 7, 2020
|
thanks |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleaning (instead of creating a dictionary of functions and then returning only one, just return the one)