TST: misplaced reduction/indexing tests #33307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1274,3 +1274,28 @@ def test_series_broadcasting(self): | |||
| df_nan.clip(lower=s, axis=0) | |||
| for op in ["lt", "le", "gt", "ge", "eq", "ne"]: | |||
| getattr(df, op)(s_nan, axis=0) | |||
|
|
|||
|
|
|||
| class TestDataFrameReductions: | |||
There was a problem hiding this comment.
There is also a tests/reductions/ directory with a lot of min/max tests. What is the general idea here of what kind of reductions tests should be placed where?
There was a problem hiding this comment.
tests.reduction is analogous to tests.arithmetic, intended for tests that are shared across classes
There was a problem hiding this comment.
hmm, you put the series ones in test_reductions.py I think these should be in a similar one?
There was a problem hiding this comment.
yah considered that, but for frame test_analytics contains most of the reduction tests. i think the thing to do is get non-reduction tests out of there and then rename to test_reduction
simonjayhawkins
added
Clean
Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.