Skip to content

CLN-29547 replace old string formatting #31844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

CLN-29547 replace old string formatting #31844

wants to merge 7 commits into from

Conversation

3vts
Copy link
Contributor

@3vts 3vts commented Feb 10, 2020 •
edited
Loading

No description provided.

@3vts 3vts requested a review from ShaharNaveh February 10, 2020 06:49
@MarcoGorelli
Copy link
Member

Thanks @3vts

Looks like you need to run black against any Python file you've modified, see contributing to the code base

@jreback
Copy link
Contributor

jreback commented Feb 10, 2020

@3vts this PR is too big

keep the modifications to < 10 files as a time

@3vts
Copy link
Contributor Author

3vts commented Feb 10, 2020

@MarcoGorelli I did, the error came when I resolved conflicts
@jreback will do, sorry, new here.....

@3vts 3vts mentioned this pull request Feb 11, 2020
Closed
@3vts 3vts closed this Feb 11, 2020
@3vts 3vts deleted the CLN-29547-Replace-old-string-formatting branch February 11, 2020 15:05
This was referenced Feb 12, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaharNaveh ShaharNaveh Awaiting requested review from ShaharNaveh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3vts @MarcoGorelli @jreback