Skip to content

CLN: 29547 replace old string formatting #32034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

3vts
Copy link
Contributor

@3vts 3vts commented Feb 16, 2020

I splitted PR #31844 in batches, this is the last
For this PR I ran the command grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/ and checked all the files that were returned for .format( and changed the old string format for the corresponding fstrings to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in case

@3vts 3vts marked this pull request as ready for review February 16, 2020 08:45
@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Feb 16, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3vts for the PR. a few comments/queries

@3vts 3vts requested a review from simonjayhawkins February 17, 2020 03:15
Alvaro Santiesteban and others added 2 commits February 17, 2020 03:19
@simonjayhawkins
Copy link
Member

@3vts thanks for making the changes. lgtm. can you run black to get ci passing

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 17, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3vts lgtm pending green

@ShaharNaveh
Copy link
Member

I splitted PR #31844 in batches, this is the last
For this PR I ran the command grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/ and checked all the files that were returned for .format( and changed the old string format for the corresponding fstrings to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in case

* [ x  ] tests added / passed

* [ x ] passes `black pandas`

* [ x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

* [ x ] closes #29547 (?)

@3vts Can you please change the last line from Closes #29547 to Ref #29547, Just so it won't close the master issue

@3vts 3vts requested a review from ShaharNaveh February 18, 2020 03:13
@3vts 3vts requested a review from simonjayhawkins February 18, 2020 03:13
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revert of the None stuff, but why the revert of the repr() changes?

@3vts 3vts requested a review from simonjayhawkins February 18, 2020 12:38
This reverts commit 226b72d.
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3vts lgtm. @MomIsBestFriend

Copy link
Member

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3vts 3vts requested a review from WillAyd February 19, 2020 19:23
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on repr changes - should just use quotes instead

@3vts 3vts requested a review from WillAyd February 20, 2020 06:19
@3vts 3vts requested a review from WillAyd February 20, 2020 23:02
@WillAyd WillAyd merged commit 73b2622 into pandas-dev:master Feb 20, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 20, 2020

Thanks @3vts

General comment - would be nice to keep PRs more minimal in the future. This was maybe an exception because of all of the double curly braces at play, but if something else comes up the same in the future should tackle in smaller bits

@3vts 3vts deleted the CLN-29547-Replace-old-string-formatting branch February 21, 2020 01:29
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants