-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: 29547 replace old string formatting #32034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: 29547 replace old string formatting #32034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @3vts for the PR. a few comments/queries
Co-Authored-By: Simon Hawkins <[email protected]>
…hub.com/3vts/pandas into CLN-29547-Replace-old-string-formatting
Co-Authored-By: Simon Hawkins <[email protected]>
…hub.com/3vts/pandas into CLN-29547-Replace-old-string-formatting
@3vts thanks for making the changes. lgtm. can you run black to get ci passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @3vts lgtm pending green
@3vts Can you please change the last line from |
This reverts commit 9fd0c7b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revert of the None stuff, but why the revert of the repr() changes?
This reverts commit 226b72d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @3vts lgtm. @MomIsBestFriend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on repr changes - should just use quotes instead
This reverts commit ff3e5d2.
Thanks @3vts General comment - would be nice to keep PRs more minimal in the future. This was maybe an exception because of all of the double curly braces at play, but if something else comes up the same in the future should tackle in smaller bits |
I splitted PR #31844 in batches, this is the last
For this PR I ran the command
grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/
and checked all the files that were returned for.format(
and changed the old string format for the correspondingfstrings
to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in caseblack pandas
git diff upstream/master -u -- "*.py" | flake8 --diff