Skip to content

CLN-29547 replace old string formatting #31878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

CLN-29547 replace old string formatting #31878

wants to merge 1 commit into from

Conversation

3vts
Copy link
Contributor

@3vts 3vts commented Feb 11, 2020

I splitted PR #31844 in batches, this is the first one
For this PR I ran the command grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/ and checked all the files that were returned for .format( and changed the old string format for the corresponding fstrings to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in case

  • [ x ] tests added / passed
  • [ x ] passes black pandas
  • [ x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff

@3vts 3vts closed this Feb 11, 2020
@3vts 3vts deleted the CLN-29547-Replace-old-string-formatting-1 branch February 11, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant