CLN: 29547 replace old string formatting 3

[3vts]

I splitted PR #31844 in batches, this is the third
For this PR I ran the command grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/ and checked all the files that were returned for .format( and changed the old string format for the corresponding fstrings to attempt a full clean of, #29547. I may have missed something so is a good idea to double check just in case

• [ x ] tests added / passed
• [ x ] passes black pandas
• [ x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff

[jreback]

@simonjayhawkins @WillAyd do we have a poilicy on this? e.g. i don't think its a big deal to have extra f'' on lines that don't need them.

[simonjayhawkins]

@simonjayhawkins @WillAyd do we have a poilicy on this? e.g. i don't think its a big deal to have extra f'' on lines that don't need them.

yeah, no big deal since we don't have code check to enforce.

my preference would be to not include but would not request changes on a PR that does.

however, would accept clean-up PRs that remove unused.

[3vts]

@simonjayhawkins @WillAyd do we have a poilicy on this? e.g. i don't think its a big deal to have extra f'' on lines that don't need them.

yeah, no big deal since we don't have code check to enforce.

my preference would be to not include but would not request changes on a PR that does.

however, would accept clean-up PRs that remove unused.

Ok will clean it since there is no gain and this is a cleanup anyways

[simonjayhawkins]

Ok will clean it since there is no gain and this is a cleanup anyways

yeah, that's probably the objection here, the intentional adding of the unused string literal prefixes.

[pep8speaks]

Hello @3vts! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-13 19:36:56 UTC

[simonjayhawkins]

@3vts lgtm pending green. one comment. not blocker.

[simonjayhawkins]

Thanks @3vts