DEPR: Deprecate numpy argument in read_json #28562

lucaionescu · 2019-09-21T13:39:59Z

closes DEPR: Deprecate numpy argument in read_json #28512
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pandas/tests/io/json/test_pandas.py

WillAyd · 2019-09-22T21:50:59Z

I think you have to catch the warnings now to prevent test failures. You can use #27103 as a reference for how this is done

lucaionescu · 2019-09-24T14:29:07Z

Do you mean using the @pytest.mark.filterwarnings("ignore:.*msgpack:FutureWarning")wrapper around the test function and this snippet?

with catch_warnings():
    filterwarnings('ignore', category=FutureWarning)

WillAyd · 2019-09-24T15:19:40Z

The context manager would be cleaner if you want to go that route

lucaionescu · 2019-09-25T07:35:00Z

I don't understand why the tests fail here, can you point me in the right direction please?

gfyoung · 2019-09-25T08:21:28Z

I don't understand why the tests fail here

In general, the test results show you every test that fails, so you can go to each one and see why each is failing. Of course, this is not practical when there are hundreds of failures.

The reason is that there are a lot more tests that pass in numpy=True to read_json than you have accounted for with this context manager.

@WillAyd : Any thoughts on how we could apply this context manager to all of the failing tests? Copy-pasting that setup across all of them seems a bit tedious (might need some abstracted wrapper to handle that for the time being) 🤷‍♂

WillAyd · 2019-10-01T04:10:04Z

I think if there's a way to limit the filter to the numpy argument at global scope would also work

jbrockmendel · 2019-10-21T01:27:15Z

@lucaionescu can you run isort -rc pandas? i think that will fix the failing CI check

jbrockmendel · 2019-10-31T22:46:07Z

@lucaionescu can you rebase? theres a decent chance that the CI failures are unrelated things that have been fixed in the last few days

jbrockmendel · 2019-11-18T21:57:54Z

@lucaionescu can you rebase?

lucaionescu · 2019-11-21T18:10:01Z

Sorry for that! I'm going to fix it ASAP 😄

WillAyd · 2019-11-29T18:06:25Z

@lucaionescu looks like there are no committed changes here - can you take a look?

WillAyd · 2019-12-17T17:58:50Z

@lucaionescu can you take a look here? Would be nice to deprecate this before 1.0

* Refer to public API * Fixed formatting * Remove ref to undocumented function

* API: Return BoolArray for string ops

#30332 (#30348)

* CLN: remove py2-legacy UnicodeReader, UnicodeWriter * remove unnecessar y writer_kwargs

* TYP * Update multi.py

This reverts commit 104fc11.

This reverts commit df2671b, reversing changes made to 104fc11.

jbrockmendel · 2019-12-31T16:42:39Z

@lucaionescu can you rebase

alimcmaster1 · 2020-01-01T13:58:32Z

@lucaionescu let us know if you still want to work on this. If not I can potentially take a look.

Thanks.

lucaionescu · 2020-01-02T15:37:04Z

@alimcmaster1 yes, that would be nice. I don't know what the best way to proceed would be with the failing tests.

WillAyd · 2020-01-03T02:44:28Z

superseded by #30636

gfyoung added Deprecate Functionality to remove in pandas ExtensionArray Extending pandas with custom dtypes or arrays. IO JSON read_json, to_json, json_normalize labels Sep 22, 2019

gfyoung reviewed Sep 22, 2019

View reviewed changes

pandas/tests/io/json/test_pandas.py Outdated Show resolved Hide resolved

lucaionescu closed this Dec 18, 2019

add original changes.

5a5b347

lucaionescu reopened this Dec 18, 2019

proost and others added 11 commits December 18, 2019 22:20

ENH: Add support for DataFrame(Categorical) (#11363) (#30305)

18bd98f

DOC: whatsnew fixups (#30331)

416907d

* Refer to public API * Fixed formatting * Remove ref to undocumented function

CLN: changed .format to f-string in pandas/core/dtypes (#30287)

f36eac1

Fix typos, via a Levenshtein-style corrector (#30341)

70a083f

TYPING: Enable --check-untyped-defs for MyPy (#29493)

20e4c18

BUG: Fix infer_dtype_from_scalar to infer IntervalDtype (#30339)

53a0dfd

API: Return BoolArray for string ops when backed by StringArray (#30239)

5b25df2

* API: Return BoolArray for string ops

REF: change parameter name fname -> path (#30338)

f8b9ce7

CLN: make lookups explicit instead of using globals (#30343)

8cbfd06

REF: remove pytables Table.metadata (#30342)

2bfd10c

REF: pytables prepare to make _create_axes return a new object (#30344)

95e1a63

souvik3333 and others added 24 commits December 19, 2019 18:40

DOC: "Next" link from user_guide/io.rst goes to read_sql_table API page

c521a4e

#30332 (#30348)

CI: troubleshoot codecov (#30070)

b4343ef

BUG+TST: non-optimized apply_index and empty DatetimeIndex (#30336)

66038e9

REF: define NA_VALUES in libparsers (#30373)

a9e2566

[CLN] remove now-unnecessary td.skip_if_no(pathlib) (#30376)

eadaa40

REF: directory for method-specific series/frame tests (#30362)

1be80ea

REF: refactor cumulative op tests from test_analytics (#30358)

a6b047a

Cleaned up Tempita refs and Cython import (#30330)

9296849

CLN: Old string formatting: .format() -> f"" (#30328)

6efc237

de-privatize io.common functions (#30368)

0df8858

CLN: remove py2-legacy UnicodeReader, UnicodeWriter (#30371)

0cd388f

* CLN: remove py2-legacy UnicodeReader, UnicodeWriter * remove unnecessar y writer_kwargs

CI: troubleshoot codecov (#30380)

8376067

CLN: move code out of try clause in merge.py (#30382)

c869255

TYP: Annotations in core/indexes/ (#30390)

477b2d5

* TYP * Update multi.py

DOC: fix external links + favicon (#30389)

835f207

STY: Underscores for long numbers (#30397)

a2bbdb5

fix call of tm.assert_frame_equal

104fc11

add original changes.

97b182b

fix call of tm.assert_frame_equal

3c8f95b

merge.

df2671b

Revert "fix call of tm.assert_frame_equal"

f46426e

This reverts commit 104fc11.

Revert "merge."

0be5dd7

This reverts commit df2671b, reversing changes made to 104fc11.

fix tm.assert_frame_equal. use naming conventions.

16217f0

sort imports correctly.

640f729

alimcmaster1 mentioned this pull request Jan 3, 2020

DEPR: Deprecate numpy argument in read_json #30636

Merged

1 task

WillAyd closed this Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: Deprecate numpy argument in read_json #28562

DEPR: Deprecate numpy argument in read_json #28562

lucaionescu commented Sep 21, 2019 •

edited

Loading

WillAyd commented Sep 22, 2019

lucaionescu commented Sep 24, 2019 •

edited

Loading

WillAyd commented Sep 24, 2019

lucaionescu commented Sep 25, 2019 •

edited

Loading

gfyoung commented Sep 25, 2019 •

edited

Loading

WillAyd commented Oct 1, 2019

jbrockmendel commented Oct 21, 2019

jbrockmendel commented Oct 31, 2019

jbrockmendel commented Nov 18, 2019

lucaionescu commented Nov 21, 2019

WillAyd commented Nov 29, 2019

WillAyd commented Dec 17, 2019

jbrockmendel commented Dec 31, 2019

alimcmaster1 commented Jan 1, 2020

lucaionescu commented Jan 2, 2020

WillAyd commented Jan 3, 2020

DEPR: Deprecate numpy argument in read_json #28562

DEPR: Deprecate numpy argument in read_json #28562

Conversation

lucaionescu commented Sep 21, 2019 • edited Loading

WillAyd commented Sep 22, 2019

lucaionescu commented Sep 24, 2019 • edited Loading

WillAyd commented Sep 24, 2019

lucaionescu commented Sep 25, 2019 • edited Loading

gfyoung commented Sep 25, 2019 • edited Loading

WillAyd commented Oct 1, 2019

jbrockmendel commented Oct 21, 2019

jbrockmendel commented Oct 31, 2019

jbrockmendel commented Nov 18, 2019

lucaionescu commented Nov 21, 2019

WillAyd commented Nov 29, 2019

WillAyd commented Dec 17, 2019

jbrockmendel commented Dec 31, 2019

alimcmaster1 commented Jan 1, 2020

lucaionescu commented Jan 2, 2020

WillAyd commented Jan 3, 2020

lucaionescu commented Sep 21, 2019 •

edited

Loading

lucaionescu commented Sep 24, 2019 •

edited

Loading

lucaionescu commented Sep 25, 2019 •

edited

Loading

gfyoung commented Sep 25, 2019 •

edited

Loading