Skip to content

CLN: changed .format to f-string in pandas/core/dtypes #30287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

CLN: changed .format to f-string in pandas/core/dtypes #30287

merged 1 commit into from
Dec 18, 2019

Conversation

DorAmram
Copy link
Contributor

@DorAmram DorAmram commented Dec 16, 2019 •
edited
Loading

@simonjayhawkins
Copy link
Member

@DorAmram Thanks for the PR. There are lint failures. Can you run black pandas, see https://dev.pandas.io/docs/development/contributing.html#python-pep8-black

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Dec 16, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 16, 2019
@DorAmram DorAmram force-pushed the using_fstrings branch 2 times, most recently from 9ea8b34 to 4672595 Compare December 16, 2019 11:29
@jbrockmendel
Copy link
Member

Still needs black pandas/core/dtypes/common.py to get the linter to be happy

simonjayhawkins
simonjayhawkins approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DorAmram Thanks for the update. lgtm.

@topper-123 topper-123 merged commit f36eac1 into pandas-dev:master Dec 18, 2019
@topper-123
Copy link
Contributor

Thanks @DorAmram!

topper-123
topper-123 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@DorAmram @proost
CLN: changed .format to f-string in pandas/core/dtypes (pandas-dev#30287
c921155 
)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@DorAmram @proost
CLN: changed .format to f-string in pandas/core/dtypes (pandas-dev#30287
2e7b80f 
)
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@DorAmram @AlexKirko
CLN: changed .format to f-string in pandas/core/dtypes (pandas-dev#30287
0bc03a9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DorAmram @simonjayhawkins @jbrockmendel @topper-123