ENH: Add support for DataFrame(ExtensionArray) #30305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/frame.py
Outdated
| @@ -450,7 +450,7 @@ def __init__( | |||
|
|
|||
| # For data is list-like, or Iterable (will consume into list) | |||
| elif isinstance(data, abc.Iterable) and not isinstance(data, (str, bytes)): | |||
| if not isinstance(data, abc.Sequence): | |||
| if not isinstance(data, (abc.Sequence, Categorical)): | |||
There was a problem hiding this comment.
Should this be any extension dtype? Not just categorical?
There was a problem hiding this comment.
@TomAugspurger
Yes. you are right. Thank you for pointing out. So I change it. Also add test case too except "DatetimeArray" and "TimedeltaArray". Because these are currently experimental and also these have no reshape method so can't use "assert_frame_equal".
proost
force-pushed
the
ENH-Dataframe-categorical-constructor
branch
from
fb6a3ee to
8d1abe2
Compare
proost
force-pushed
the
ENH-Dataframe-categorical-constructor
branch
from
8d1abe2 to
35d502f
Compare
topper-123
changed the title
|
Thanks, @proost |
proost
added a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
added a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffProblem:
In core.frame
Categorical Object cast as list. So In core.construction it is not identified as Categorical.