TYP: Annotations in core/indexes/ #30390
Conversation
| """Return the dtype object of the underlying data""" | ||
| """ | ||
| Return the dtype object of the underlying data. | ||
| """ |
There was a problem hiding this comment.
IIRC docstrings that fit on a single line are allowed. I don't really have an opinion on this, but would much rather see you implement e.g. #28115 (not on the list i suggested previously) than this.
There was a problem hiding this comment.
Gotta be honest, I have no clue where to start with.
And I really appreciate the fact you want me to be more involved, means a lot to me.
There was a problem hiding this comment.
Gotta be honest, I have no clue where to start with.
I suggested #28115 because it is relatively straightforward as a stepping-stone. You would need to go to the pd.Timestamp class and define a fromisocalendar method on it that behaves just like the datetime.datetime version, but returning a Timestamp.
There was a problem hiding this comment.
@jbrockmendel That's the exact lead I needed. thank you:)
|
Just the one typo, ping on green |
|
ping @jbrockmendel |
|
Thanks @MomIsBestFriend |
* TYP * Update multi.py
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff