CI: Fixes to conda environment names #23860
Conversation
|
@charlesdong1991 are you still working on it? The rest of the changes in the scripts and the travis and azure config described in the issue are missing. |
datapythonista
changed the title
|
Hi, so sorry that I am having dinner out, but I will carry on working after
back home.
…On Thu, 22 Nov 2018 at 20:12, Marc Garcia ***@***.***> wrote:
@charlesdong1991 <https://github.com/charlesdong1991> are you still
working on it? The rest of the changes in the scripts and the travis and
azure config described in the issue are missing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23860 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI1yODPwZQTsFVvOoFA6pY7DtOzcyRdnks5uxvcGgaJpZM4YvksU>
.
|
|
Ok, no problem. For next time, you can push your changes to your remote banch, but it's better if you don't open the PR until is complete. Or at least until it's in a state that we should review it. |
|
oh, so sorry, good to learn a lesson! I will keep this in mind, and no next
time for this mistake! sorry for this again...
…On Thu, 22 Nov 2018 at 20:24, Marc Garcia ***@***.***> wrote:
Ok, no problem. For next time, you can push your changes to your remote
banch, but it's better if you don't open the PR until is complete. Or at
least until it's in a state that we should review it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23860 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI1yOAP9Ne_Zf40jnIaJT4xP4VbRSpZcks5uxvn1gaJpZM4YvksU>
.
|
|
Not a problem at all, just said, as it make things more efficient. Enjoy your dinner, and thanks for working on this. |
Codecov Report
@@ Coverage Diff @@
## master #23860 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 161 161
Lines 51500 51500
=======================================
Hits 47528 47528
Misses 3972 3972
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #23860 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 161 161
Lines 51500 51500
=======================================
Hits 47528 47528
Misses 3972 3972
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good, thanks for working on this @charlesdong1991. Couple of comments, and they should fix the CI which is in red. If after changing them, you see the CI still red, you may want to check what else is needed.
| @@ -11,11 +11,10 @@ call deactivate | |||
| @rem Display root environment (for debugging) | |||
| conda list | |||
| @rem Clean up any left-over from a previous build | |||
| conda remove --all -q -y -n %CONDA_ENV% | |||
|
|
|||
There was a problem hiding this comment.
we may need this, but you can replace the %CONDA_ENV% by pandas-dev
| @@ -12,15 +12,15 @@ conda list | |||
| # Clean up any left-over from a previous build | |||
| # (note workaround for https://github.com/conda/conda/issues/2679: | |||
| # `conda env remove` issue) | |||
| conda remove --all -q -y -n $CONDA_ENV | |||
| conda remove --all -q -y | |||
There was a problem hiding this comment.
can you leave the -n pandas-dev
|
|
||
| # Activate first | ||
| set +v | ||
| source activate $CONDA_ENV | ||
| source activate pandas-dev |
There was a problem hiding this comment.
this one can be removed, also the set +/- v around it
Adds more idiom to the following: * parser/common --> parser/test_common * parser/quoting --> parser/test_quoting * parser/usecols --> parser/test_usecols * parser/python_parser_only --> parser/test_python_parser_only Also: * Finally delete parser/test_parsers! * Bug in capture_stdout decorator in which we were forgetting to use compat.wraps. Builds off of pandas-devgh-23712.
|
@datapythonista sorry, this is very wrong... i think i did something very bad when catching up with the latest change, i think i need to re-create a pr... sorry |
git diff upstream/master -u -- "*.py" | flake8 --diff