Skip to content

TST: Add test cases for GH6173, appending to empty df #23806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 23, 2018

Conversation

eoveson
Copy link
Contributor

@eoveson eoveson commented Nov 20, 2018

Hmm, previous check-in for GH4861 still showing in this branch, thought it wouldn't show as a diff after syncing to upstream (sorry, new to git)

@pep8speaks
Copy link

Hello @eoveson! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #23806 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23806   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51500    51500           
=======================================
  Hits        47531    47531           
  Misses       3969     3969
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e01c38...39ab773. Read the comment docs.

@jschendel jschendel added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves labels Nov 20, 2018


def test_multiindex_period_datetime():
# GH4861, using datetime in period of multiindex raises exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you duplicate this test? it is already in master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't explicitly add it again, it was just showing up in the diff for some reason. I thought I was completely up-to-date with master. Anyway, I synched again, and I think things are now in a good state because it is no longer showing in the diff.

@jreback jreback added this to the 0.24.0 milestone Nov 21, 2018
@jreback jreback merged commit 54932d0 into pandas-dev:master Nov 23, 2018
@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

thanks @eoveson

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.loc for appending/assigning multiple values
5 participants