-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Add test cases for GH6173, appending to empty df #23806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @eoveson! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23806 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 161 161
Lines 51500 51500
=======================================
Hits 47531 47531
Misses 3969 3969
Continue to review full report at Codecov.
|
|
||
|
||
def test_multiindex_period_datetime(): | ||
# GH4861, using datetime in period of multiindex raises exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you duplicate this test? it is already in master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't explicitly add it again, it was just showing up in the diff for some reason. I thought I was completely up-to-date with master. Anyway, I synched again, and I think things are now in a good state because it is no longer showing in the diff.
thanks @eoveson |
git diff upstream/master -u -- "*.py" | flake8 --diff
Hmm, previous check-in for GH4861 still showing in this branch, thought it wouldn't show as a diff after syncing to upstream (sorry, new to git)