CLN: Isort core/*.py and core/indexes/ #23764

alimcmaster1 · 2018-11-18T12:10:36Z

xref Fix import formatting using isort #23334
passes git diff upstream/master -u -- "*.py" | flake8 --diff

pep8speaks · 2018-11-18T12:10:57Z

Hello @alimcmaster1! Thanks for submitting the PR.

There are no PEP8 issues in the file pandas/conftest.py !
There are no PEP8 issues in the file pandas/core/algorithms.py !
There are no PEP8 issues in the file pandas/core/api.py !
There are no PEP8 issues in the file pandas/core/apply.py !
There are no PEP8 issues in the file pandas/core/base.py !
There are no PEP8 issues in the file pandas/core/categorical.py !
There are no PEP8 issues in the file pandas/core/common.py !
There are no PEP8 issues in the file pandas/core/config.py !
There are no PEP8 issues in the file pandas/core/config_init.py !
There are no PEP8 issues in the file pandas/core/frame.py !
There are no PEP8 issues in the file pandas/core/generic.py !
There are no PEP8 issues in the file pandas/core/indexes/accessors.py !
There are no PEP8 issues in the file pandas/core/indexes/api.py !
There are no PEP8 issues in the file pandas/core/indexes/base.py !
There are no PEP8 issues in the file pandas/core/indexes/category.py !
There are no PEP8 issues in the file pandas/core/indexes/frozen.py !
There are no PEP8 issues in the file pandas/core/indexes/interval.py !
There are no PEP8 issues in the file pandas/core/indexes/multi.py !
There are no PEP8 issues in the file pandas/core/indexes/numeric.py !
There are no PEP8 issues in the file pandas/core/indexes/period.py !
There are no PEP8 issues in the file pandas/core/indexing.py !
There are no PEP8 issues in the file pandas/core/missing.py !
There are no PEP8 issues in the file pandas/core/nanops.py !
There are no PEP8 issues in the file pandas/core/ops.py !
There are no PEP8 issues in the file pandas/core/panel.py !
There are no PEP8 issues in the file pandas/core/resample.py !
There are no PEP8 issues in the file pandas/core/sorting.py !
There are no PEP8 issues in the file pandas/core/strings.py !
There are no PEP8 issues in the file pandas/core/window.py !

jbrockmendel · 2018-11-19T01:02:16Z

pandas/core/apply.py

+    is_dict_like, is_extension_type, is_list_like, is_sequence)
+from pandas.core.dtypes.generic import ABCSeries
+
+from pandas import compat


Can you make this “import pandas.compat as compat”? That will group it with the appropriate level of dependencies. Same in other files if it comes up.

Thanks for this ~11 files in this PR. ( Will make this change in my other PR too )

jbrockmendel · 2018-11-19T01:03:52Z

pandas/core/generic.py

 import pandas.core.missing as missing
+import pandas.core.nanops as nanops


Can you put this in the same line as “from pandas.core import config”? Dittto “missing” one line up

Updated, thanks

jbrockmendel · 2018-11-19T01:06:26Z

pandas/core/indexes/api.py

+import pandas.core.common as com
+from pandas.core.indexes.base import (
+    Index, _new_Index, ensure_index, ensure_index_from_sequences)
+from pandas.core.indexes.base import InvalidIndexError  # noqa


Her and elsewhere can you make the “noqa” specific? I think it’s “noqa: F401”

Sure makes sense! Thanks

codecov · 2018-11-19T23:41:42Z

Codecov Report

Merging #23764 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #23764      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         161      161              
  Lines       51500    51497       -3     
==========================================
- Hits        47528    47525       -3     
  Misses       3972     3972

Flag	Coverage Δ
#multiple	`90.68% <100%> (-0.01%)`	⬇️
#single	`42.31% <98.97%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/indexes/accessors.py	`91.08% <100%> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.49% <100%> (-0.01%)`	⬇️
pandas/core/base.py	`97.6% <100%> (-0.01%)`	⬇️
pandas/core/resample.py	`96.99% <100%> (ø)`	⬆️
pandas/core/config.py	`87.17% <100%> (ø)`	⬆️
pandas/core/ops.py	`94.27% <100%> (ø)`	⬆️
pandas/core/indexes/period.py	`93.07% <100%> (ø)`	⬆️
pandas/core/algorithms.py	`95.11% <100%> (ø)`	⬆️
pandas/core/indexes/category.py	`97.87% <100%> (ø)`	⬆️
pandas/core/indexes/numeric.py	`97.32% <100%> (ø)`	⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e405a10...4fd7150. Read the comment docs.

alimcmaster1 · 2018-11-20T00:10:38Z

@jbrockmendel thanks for the review updated as per your comments

jreback · 2018-11-20T02:02:03Z

can you merge master. ping on green.

alimcmaster1 · 2018-11-22T00:36:54Z

setup.cfg

-    pandas/core/indexing.py,
-    pandas/core/apply.py,
-    pandas/core/generic.py,
-    pandas/core/sorting.py,
    pandas/core/frame.py,


Sorting frame.py seems to cause a few problems will address this in separate PR

alimcmaster1 · 2018-11-22T01:29:28Z

merged master and green - cc. @jreback

jreback · 2018-11-23T02:55:17Z

thanks @alimcmaster1

WillAyd added the Clean label Nov 18, 2018

jbrockmendel reviewed Nov 19, 2018

View reviewed changes

alimcmaster1 added 5 commits November 21, 2018 23:24

isort core

f0a911e

Isort period

0496fd4

Fix compat imports

000cfe3

More specific noqa

0a1a533

Merge latest

4fd7150

alimcmaster1 commented Nov 22, 2018

View reviewed changes

jreback added this to the 0.24.0 milestone Nov 23, 2018

jreback added the Code Style Code style, linting, code_checks label Nov 23, 2018

jreback merged commit 8edf972 into pandas-dev:master Nov 23, 2018

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CLN: Isort core/*.py and core/indexes/ (pandas-dev#23764)

5c9de28

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CLN: Isort core/*.py and core/indexes/ (pandas-dev#23764)

ece7a52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN: Isort core/*.py and core/indexes/ #23764

CLN: Isort core/*.py and core/indexes/ #23764

alimcmaster1 commented Nov 18, 2018

pep8speaks commented Nov 18, 2018

jbrockmendel Nov 19, 2018

alimcmaster1 Nov 19, 2018

jbrockmendel Nov 19, 2018

alimcmaster1 Nov 20, 2018

jbrockmendel Nov 19, 2018

alimcmaster1 Nov 19, 2018

codecov bot commented Nov 19, 2018 •

edited

Loading

alimcmaster1 commented Nov 20, 2018

jreback commented Nov 20, 2018

alimcmaster1 Nov 22, 2018

alimcmaster1 commented Nov 22, 2018 •

edited

Loading

jreback commented Nov 23, 2018

		import pandas.core.missing as missing
		import pandas.core.nanops as nanops

CLN: Isort core/*.py and core/indexes/ #23764

CLN: Isort core/*.py and core/indexes/ #23764

Conversation

alimcmaster1 commented Nov 18, 2018

pep8speaks commented Nov 18, 2018

jbrockmendel Nov 19, 2018

Choose a reason for hiding this comment

alimcmaster1 Nov 19, 2018

Choose a reason for hiding this comment

jbrockmendel Nov 19, 2018

Choose a reason for hiding this comment

alimcmaster1 Nov 20, 2018

Choose a reason for hiding this comment

jbrockmendel Nov 19, 2018

Choose a reason for hiding this comment

alimcmaster1 Nov 19, 2018

Choose a reason for hiding this comment

codecov bot commented Nov 19, 2018 • edited Loading

Codecov Report

alimcmaster1 commented Nov 20, 2018

jreback commented Nov 20, 2018

alimcmaster1 Nov 22, 2018

Choose a reason for hiding this comment

alimcmaster1 commented Nov 22, 2018 • edited Loading

jreback commented Nov 23, 2018

codecov bot commented Nov 19, 2018 •

edited

Loading

alimcmaster1 commented Nov 22, 2018 •

edited

Loading