Skip to content

CI: Fixes to conda environment names #23860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ before_script:
- ci/before_script_travis.sh

script:
- source activate pandas-dev
- echo "script start"
- ci/run_build_docs.sh
- ci/script_single.sh
Expand All @@ -115,7 +116,7 @@ after_success:

after_script:
- echo "after_script start"
- source activate pandas && pushd /tmp && python -c "import pandas; pandas.show_versions();" && popd
- source activate pandas-dev && pushd /tmp && python -c "import pandas; pandas.show_versions();" && popd
- if [ -e test-data-single.xml ]; then
ci/print_skipped.py test-data-single.xml;
fi
Expand Down
2 changes: 0 additions & 2 deletions ci/build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ if [ "$DOC" ]; then

echo "Will build docs"

source activate pandas

echo ###############################
echo # Log file for the doc build #
echo ###############################
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-27-compat.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-36-locale_slow.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-locale.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-macos-35.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-27.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-36.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/circle-36-locale.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-27-locale.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-27.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-doc.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-slow.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-37-numpydev.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-37.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pandas
name: pandas-dev
channels:
- defaults
- conda-forge
Expand Down
2 changes: 1 addition & 1 deletion ci/incremental/build.cmd
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@rem https://github.com/numba/numba/blob/master/buildscripts/incremental/build.cmd
call activate %CONDA_ENV%


@rem Build numba extensions without silencing compile errors
python setup.py build_ext -q --inplace
Expand Down
1 change: 0 additions & 1 deletion ci/incremental/build.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/bash

source activate $CONDA_ENV

# Make sure any error below is reported as such
set -v -e
Expand Down
5 changes: 2 additions & 3 deletions ci/incremental/setup_conda_environment.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@ call deactivate
@rem Display root environment (for debugging)
conda list
@rem Clean up any left-over from a previous build
conda remove --all -q -y -n %CONDA_ENV%

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need this, but you can replace the %CONDA_ENV% by pandas-dev

@rem Scipy, CFFI, jinja2 and IPython are optional dependencies, but exercised in the test suite
conda env create -n %CONDA_ENV% --file=ci\deps\azure-windows-%CONDA_PY%.yaml
conda env create --file=ci\deps\azure-windows-%CONDA_PY%.yaml

call activate %CONDA_ENV%
conda list

if %errorlevel% neq 0 exit /b %errorlevel%
6 changes: 3 additions & 3 deletions ci/incremental/setup_conda_environment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ conda list
# Clean up any left-over from a previous build
# (note workaround for https://github.com/conda/conda/issues/2679:
# `conda env remove` issue)
conda remove --all -q -y -n $CONDA_ENV
conda remove --all -q -y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave the -n pandas-dev


echo
echo "[create env]"
time conda env create -q -n "${CONDA_ENV}" --file="${ENV_FILE}" || exit 1
time conda env create -q --file="${ENV_FILE}" || exit 1

# Activate first
set +v
source activate $CONDA_ENV
source activate pandas-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one can be removed, also the set +/- v around it

set -v

# remove any installed pandas package
Expand Down
1 change: 0 additions & 1 deletion ci/script_single.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

echo "[script_single]"

source activate pandas

if [ -n "$LOCALE_OVERRIDE" ]; then
echo "Setting LC_ALL and LANG to $LOCALE_OVERRIDE"
Expand Down
1 change: 0 additions & 1 deletion ci/upload_coverage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ if [ -z "$COVERAGE" ]; then
exit 0
fi

source activate pandas

echo "uploading coverage"
bash <(curl -s https://codecov.io/bash) -Z -c -F single -f /tmp/cov-single.xml
Expand Down