REF: strictness/simplification in DatetimeArray/Index _simple_new #23431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
4 tasks
gfyoung
added
Refactor
gfyoung
reviewed
Oct 31, 2018
| assert isinstance(values, np.ndarray), "values is not an np.ndarray" | ||
| assert is_datetime64_dtype(values) | ||
| # DatetimeArray._simple_new will accept either i8 or M8[ns] dtypes | ||
| assert isinstance(values, np.ndarray), type(values) |
There was a problem hiding this comment.
Same questions for all your assert statements:
- Are these internal? If not, it would be nice to have user-friendly error messages.
- Can these
assertstatements be tested in any way?
Codecov Report
@@ Coverage Diff @@
## master #23431 +/- ##
==========================================
+ Coverage 92.21% 92.22% +<.01%
==========================================
Files 161 161
Lines 51173 51174 +1
==========================================
+ Hits 47190 47196 +6
+ Misses 3983 3978 -5
Continue to review full report at Codecov.
|
jreback
requested changes
Nov 1, 2018
|
This (and to a lesser extent #23430) is turning into a blocker for work on DatetimeArray. (its easy to re-implement this in that branch, but still) |
jreback
approved these changes
Nov 2, 2018
|
thanks |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Nov 3, 2018
…xamples * repo_org/master: (66 commits) CLN: doc string (pandas-dev#23469) DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032) add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150) BUG: Allow freq conversion from dt64 to period (pandas-dev#23460) ENH: Add FrozenList.union and .difference (pandas-dev#23394) REF: cython cleanup, typing, optimizations (pandas-dev#23464) strictness and checks for Timedelta _simple_new (pandas-dev#23433) Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472) DOC: Updating the docstring of Series.dot (pandas-dev#22890) TST: Fixturize series/test_analytics.py (pandas-dev#22755) BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406) PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404) REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430) REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431) REF: cython cleanup, typing, optimizations (pandas-dev#23456) TST: tweak Hypothesis configuration and idioms (pandas-dev#23441) BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435) TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442) BUG: Deprecate nthreads argument (pandas-dev#23112) style: fix import format at pandas/core/reshape (pandas-dev#23387) ...
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off of #23426. The edits to DatetimeIndex._simple_new go beyond what is done there.