REF: Remove DatetimelikeArrayMixin._shallow_copy #23430
Conversation
|
Hello @jbrockmendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23430 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 161 161
Lines 51173 51168 -5
==========================================
- Hits 47190 47185 -5
Misses 3983 3983
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
|
Looks fine to me. A couple of points:
|
If anything, it removes a level of function-call overhead. Should not make a measurable impact.
_shallow_copy was implemented in these EA mixin classes to make them play nicely when inherited by their respective Index subclasses. We are moving away from having these get mixed in, and do not need _shallow_copy in the standalone EA subclasses. |
|
thanks |
| @@ -586,7 +586,7 @@ def tz_convert(self, tz): | |||
| 'tz_localize to localize') | |||
|
|
|||
| # No conversion since timestamps are all UTC to begin with | |||
| return self._shallow_copy(tz=tz) | |||
| return self._simple_new(self.asi8, tz=tz, freq=self.freq) | |||
There was a problem hiding this comment.
Why self.asi8 and not self or self._data here? Simple_new doesn't take M8 values?
There was a problem hiding this comment.
_simple_new(int64values, tz=tz) will get you the same thing as __new__(int64values, tz=tz), but the same is not true with M8 values. I find that really helpful.
There was a problem hiding this comment.
You are referring to the timezone difference you mentioned earlier?
I personally find that very confusing that DatetimeArray(self._data, tz=..) and DatetimeArray(self._data.view(int), tz=..) do not give the same. To the extent possible, I would not repeat this pattern for our Arrays?
(of course, in the DatetimeIndex constructor we cannot just change it, unless we want to deprecate that first).
…xamples * repo_org/master: (66 commits) CLN: doc string (pandas-dev#23469) DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032) add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150) BUG: Allow freq conversion from dt64 to period (pandas-dev#23460) ENH: Add FrozenList.union and .difference (pandas-dev#23394) REF: cython cleanup, typing, optimizations (pandas-dev#23464) strictness and checks for Timedelta _simple_new (pandas-dev#23433) Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472) DOC: Updating the docstring of Series.dot (pandas-dev#22890) TST: Fixturize series/test_analytics.py (pandas-dev#22755) BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406) PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404) REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430) REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431) REF: cython cleanup, typing, optimizations (pandas-dev#23456) TST: tweak Hypothesis configuration and idioms (pandas-dev#23441) BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435) TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442) BUG: Deprecate nthreads argument (pandas-dev#23112) style: fix import format at pandas/core/reshape (pandas-dev#23387) ...
Broken off of #23426.