Skip to content

TST: Fixturize series/test_analytics.py #22755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

Anjali2019
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Sep 18, 2018

Hello @Anjali2019! Thanks for updating the PR.

Comment last updated on September 18, 2018 at 23:23 Hours UTC

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Sep 23, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 23, 2018

@Anjali2019 : We recently dropped the AppVeyor build. Can you rebase?

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #22755 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22755      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         161      161              
  Lines       51187    51187              
==========================================
- Hits        47202    47200       -2     
- Misses       3985     3987       +2
Flag Coverage Δ
#multiple 90.64% <ø> (-0.01%) ⬇️
#single 42.21% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 86.64% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9019582...8a69d29. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 7, 2018

rebase and ping on green

@jreback
Copy link
Contributor

jreback commented Nov 1, 2018

closing as stale. if you'd like to continue pls ping.

@jreback jreback closed this Nov 1, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 1, 2018
@gfyoung
Copy link
Member

gfyoung commented Nov 1, 2018

I'd like to continue this.

@gfyoung gfyoung reopened this Nov 1, 2018
@gfyoung gfyoung force-pushed the tst_series_analytics branch from ebf0e10 to 8a69d29 Compare November 1, 2018 07:10
@gfyoung
Copy link
Member

gfyoung commented Nov 1, 2018

@jreback : Any comments on this?

@jreback jreback merged commit 4f71755 into pandas-dev:master Nov 2, 2018
@jreback
Copy link
Contributor

jreback commented Nov 2, 2018

thanks @Anjali2019 and @gfyoung

thoo added a commit to thoo/pandas that referenced this pull request Nov 3, 2018
…xamples

* repo_org/master: (66 commits)
  CLN: doc string (pandas-dev#23469)
  DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032)
  add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150)
  BUG: Allow freq conversion from dt64 to period (pandas-dev#23460)
  ENH: Add FrozenList.union and .difference (pandas-dev#23394)
  REF: cython cleanup, typing, optimizations (pandas-dev#23464)
  strictness and checks for Timedelta _simple_new (pandas-dev#23433)
  Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472)
  DOC: Updating the docstring of Series.dot  (pandas-dev#22890)
  TST: Fixturize series/test_analytics.py (pandas-dev#22755)
  BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406)
  PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404)
  REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430)
  REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431)
  REF: cython cleanup, typing, optimizations (pandas-dev#23456)
  TST: tweak Hypothesis configuration and idioms (pandas-dev#23441)
  BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435)
  TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442)
  BUG: Deprecate nthreads argument (pandas-dev#23112)
  style: fix import format at pandas/core/reshape (pandas-dev#23387)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants