STYLE: Additional flake8 checks

[mroeschke]

Currently we ignore some flake8 checks:

Checks that (currently) we're okay with skipping

• E402, # module level import not at top of file
• E731, # do not assign a lambda expression, use a def
• W503 # line break before binary operator

Checks that should be run

• E741, # do not use variables named 'l', 'O', or 'I' Enforce flake8 E741 #22795 (CLN: Flake8 E741 #23131)
• C405, # Unnecessary (list/tuple) literal - rewrite as a set literal.
• C406 # Unnecessary (list/tuple) literal - rewrite as a dict literal.
• C408, # Unnecessary (dict/list/tuple) call - rewrite as a literal.
• C409, # Unnecessary (list/tuple) passed to tuple() - (remove the outer call to tuple()/rewrite as a tuple literal).
• C410 # Unnecessary (list/tuple) passed to list() - (remove the outer call to list()/rewrite as a list literal).

Ideally, we should continue to lint our codebase with reasonable flake8 checks.

[jbrockmendel]

I’d be +1 on adding E741

[jbrockmendel]

I'm noticing in test_offsets assert not MonthEnd() in _daterange_cache which I would expect flake8 to complain should be assert MonthEnd() not in _daterange_cache. Any idea why this isn't being chcked?

[jbrockmendel]

Recently saw flake8-eradicate, which looks for commented-out code. It seems to produce a lot of false-positives, so we probably wouldn't want it in the CI, just a one-time run to do a dedicated remove-it-all sweep.

[jbrockmendel]

Not sure if this is specifically flake8, but it'd be nice to use a linter to prevent creep in the dependency structure. Specifically, once a file has zero-runtime-imports, we could have a check to keep it that way.

[mroeschke]

Looks like our code checks are linting all the flake8 codes mentioned above. Going to close this issue out.