STYLE/LINT: Set literals #22202
STYLE/LINT: Set literals #22202
Conversation
|
Hello @mroeschke! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 06, 2018 at 01:18 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #22202 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 169 169
Lines 50694 50694
=======================================
Hits 46671 46671
Misses 4023 4023
Continue to review full report at Codecov.
|
| @@ -385,7 +385,7 @@ def test_convert_numeric_uint64_nan(self, coerce, arr): | |||
|
|
|||
| def test_convert_numeric_uint64_nan_values(self, coerce): | |||
| arr = np.array([2**63, 2**63 + 1], dtype=object) | |||
| na_values = set([2**63]) | |||
| na_values = {2 ** 63} | |||
There was a problem hiding this comment.
What's the convention for whitespace around **? I thought that one usually stays 2**63.
There was a problem hiding this comment.
Looks like there's some ambiguity for the convention around ** specifically: https://stackoverflow.com/questions/36794533/pep8-e226-recommendation
However this was auto-formatted automatically by PyCharm (which probably takes a strict interpretation of whitespace around arithmetic operators). I'll just convert it back to match the rest of this function (and retrigger a failed build).
|
Pending green, LGTM. |
|
I think we’re safe taking this off @jreback’s plate. Merging. Thanks @mroeschke. |
|
Thanks! |
* Style: Use set literals: * flake8: * Fix empty sets * Undo spaces
xref #22122
Use
{1, 2, 3}instead ofset([1, 2, 3])and enforce with a linting rule.