Skip to content

STY: rename filter kwarg in replace methods #26873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Jun 16, 2019 · 2 comments
Closed

STY: rename filter kwarg in replace methods #26873

jbrockmendel opened this issue Jun 16, 2019 · 2 comments
Labels
API Design

Comments

@jbrockmendel
Copy link
Member

Overlaps with builtin filter.

Could use e.g. https://pypi.org/project/flake8-builtins/ to check for other cases like this, xref #22122
@topper-123
Copy link
Contributor

I don't see that kwarg in e.g. DataFrame.replace. Could you be more specific where you see this.

@jbrockmendel
Copy link
Member Author

Block.replace, Block._replace_single, BlockManager.apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @topper-123