Skip to content

CLN: Flake8 E741 #23131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2018
Merged

CLN: Flake8 E741 #23131

merged 3 commits into from
Oct 14, 2018

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Oct 13, 2018

flake8 --select E741 now runs clean

@pep8speaks
Copy link

pep8speaks commented Oct 13, 2018

Hello @alimcmaster1! Thanks for updating the PR.

Comment last updated on October 13, 2018 at 16:10 Hours UTC

@datapythonista datapythonista added CI Continuous Integration Code Style Code style, linting, code_checks Clean labels Oct 13, 2018
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for all the work in this @alimcmaster1

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #23131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23131   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         170      170           
  Lines       51073    51073           
=======================================
  Hits        47056    47056           
  Misses       4017     4017
Flag Coverage Δ
#multiple 90.56% <ø> (ø) ⬆️
#single 42.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e1a0a...83aede4. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Oct 14, 2018
@mroeschke mroeschke mentioned this pull request Oct 14, 2018
6 tasks
@jreback jreback merged commit 21e8522 into pandas-dev:master Oct 14, 2018
@jreback
Copy link
Contributor

jreback commented Oct 14, 2018

thanks @alimcmaster1

@alimcmaster1
Copy link
Member Author

Thanks both for looking, appreciate it! @datapythonista , @jreback

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants