Skip to content

Enforce flake8 E741 #22795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2018
Merged

Enforce flake8 E741 #22795

merged 1 commit into from
Sep 20, 2018

Conversation

alimcmaster1
Copy link
Member

Enforce flake8 E741

#19496 ( Was added here )
But running flake8 --select E741 returns nothing

Looks like this is a valid flake8 rule: ( unless im looking at the wrong docs )

https://lintlyci.github.io/Flake8Rules/

@alimcmaster1
Enforce E741
8a558e2 
Enforce E741
WillAyd
WillAyd approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @TomAugspurger

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite Build Library building on various platforms labels Sep 20, 2018
@jbrockmendel
Copy link
Member

+1

@WillAyd WillAyd merged commit 8a1164c into pandas-dev:master Sep 20, 2018
@WillAyd
Copy link
Member

WillAyd commented Sep 20, 2018

Simple enough and Travis passed so I'll take @jbrockmendel 's +1 as approval to merge :-)

Thanks @alimcmaster1

@alimcmaster1
Copy link
Member Author

Thanks! @WillAyd

@mroeschke mroeschke mentioned this pull request Sep 20, 2018
Closed
6 tasks
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #22795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22795   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50804    50804           
=======================================
  Hits        46833    46833           
  Misses       3971     3971
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 42.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0480f4c...8a558e2. Read the comment docs.

@alimcmaster1 alimcmaster1 mentioned this pull request Sep 30, 2018
Merged
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@alimcmaster1
Enforce E741 (pandas-dev#22795)
fc196c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alimcmaster1 @jbrockmendel @WillAyd