Moves shell below key features #221

joelachance · 2020-04-24T02:00:54Z

I've added a Title to NumPy Shell here, and right now I'm indifferent about the result. It felt like something was missing when I moved it below Key Features, so please post thoughts and suggestions.

Resolves #220

…l title

InessaPawson

@joelachance Let’s try the following and see how we like it then:

Remove the white space above the “Key Features”. This is how it shows now:

Remove the “Key Features” title and “Learn More” below.
Remove the “NumPy Shell” title.

joelachance · 2020-04-24T14:17:14Z

@InessaPawson

I did notice the whitespace and had removed it. You might have cached styles. I'll double check though!
Without the 'Learn More', I don't think there's a CTA in that section.
Will do!

InessaPawson · 2020-04-25T09:31:32Z

I did notice the whitespace and had removed it. You might have cached styles. I'll double check though!

Clearing the cache fixed it. Thank you for the tip!

Without the 'Learn More', I don't think there's a CTA in that section.

I’m not certain if the CTA is really needed there. @MarsBarLee @rgommers what do you think?

rgommers · 2020-04-25T16:26:45Z

It felt like something was missing when I moved it below Key Features

Yeah, it's hard to explain exactly what it is, but visually the page looks less appealing to me now. Perhaps because I'm already used to the original layout, but I'm not completely sure this is an improvement.

InessaPawson · 2020-04-26T13:04:11Z

I'll submit a prototype/s with the new layout for you to make the final decision.

InessaPawson · 2020-04-28T11:55:15Z

Here are four lo-fi prototypes for your consideration.

Version 1 Key features -> News -> Shell

Version 2 Shell -> News -> Key features

Version 3 News -> Shell -> Key features

Version 4 News -> Key features -> Shell

joelachance · 2020-04-28T14:14:01Z

One suggestion if we go with the banner-style news section: We could do the blue background in CSS and allow that to stretch across the screen 100%, and simply export the rest of the image as an svg. On that note, if we are just rendering text, it'll be a bit more performant to write it in HTML. On the flip side, this could be a pain if this section changes a lot.

My preference would be v3 or v4.

rgommers · 2020-04-30T04:08:30Z

I like v4 the best, and I think it will look even better with Joe's suggestion of stretching the news bar to 100% of site width. v4 has a nice symmetry to it somehow, and fixes the thing that felt a little off with the "key features" section right under the title.

and simply export the rest of the image as an svg. On that note, if we are just rendering text, it'll be a bit more performant to write it in HTML. On the flip side, this could be a pain if this section changes a lot.

The text of that news bar will change regularly I think. The text shouldn't be inside an svg image imho, that'd be too annoying to update (unless I'm missing what you are suggesting here).

InessaPawson · 2020-04-30T07:12:04Z

For the record, I prefer Version One slightly more. I like the logic of it. First, there is an outline of the key features of the library, then an announcement (with a link) of the latest news about the project (in this example the latest stable release), then an opportunity to try out NumPy without the installation is offered.
Version Four would be my second choice.

InessaPawson · 2020-04-30T07:31:20Z

I like v4 the best, and I think it will look even better with Joe's suggestion of stretching the news bar to 100% of site width. v4 has a nice symmetry to it somehow, and fixes the thing that felt a little off with the "key features" section right under the title.

Stretching out the bar would work. And if we leave out the “Learn more” button, I would not miss it.;)

The text of that news bar will change regularly I think.

Correct. @joelachance @rgommers I understand that not everyone is comfortable editing .svg. Do you think using news class would be a better option?

InessaPawson · 2020-04-30T07:43:33Z

Here is Version 4 with updates.

joelachance · 2020-04-30T13:04:29Z

I like your v4 update, @InessaPawson!

Why don't we put news content in the config file, and have it render in html? I think this might be much less of a chore for whomever needs to update the NumPy news.

InessaPawson · 2020-05-01T09:53:23Z

I like your v4 update, @InessaPawson!

Great! I think we have consensus here.

Why don't we put news content in the config file, and have it render in html? I think this might be much less of a chore for whomever needs to update the NumPy news.

I see. It makes sense. @joelachance Please go ahead and make changes to the code.

rossbar · 2020-05-04T19:09:44Z

I'm a bit late, but I just wanted to chime in and say I like v4 best too, esp. after the update!

InessaPawson · 2020-05-05T02:27:53Z

I'm a bit late, but I just wanted to chime in and say I like v4 best too, esp. after the update!

Thank you for your feedback, @rossbar!

… to generate the same

Cleanup of README, 80char line Cleanup of README, 80char line

* DOC: Re-work EHT intro paragraph * Removed sentence about EHT sensing wavelength. * Updated wording surrounding VLBI * Switch to md reflink style for source readability * Updates to Key Imaging Objectives * Renamed the section to 'Key Goals and Results' to better fit the content. * Updated first bullet point with context and accurate date. * Minor re-wording of remaining bullet points * Modified the wording of a couple bullet points. * Made the reference to M87's black hole more explicit * Updated last bullet point of Challenges to give a higher-level overview of the imaging challeng. * Re-wrote first paragraph of NumPy's role section * Attempting to focus specifically on image reconstruction, particularly eht-imaging, where the dependence on the scientific Python ecosystem is most relevant. * Trying to provide a little background on overall reconstruction task, and tie it into why NumPy/SciPy are so important. * More reorganization of the NumPy Role section. * Moved eht-imaging up as it ties in with the theme and is the most prominent example of NumPy used in the eht analysis * Removed paragraph on CHIRP: - Trying to reduced redundancy given previous discussion on data processing - CHIRP is not available on GH - not sure to what extent NumPy is used for that particular pkg * Removed additional paragraph on regularized MLEM - want to avoid too much detail and focusing on algorithms * Re-wording of the summary. * replaced vectors/matrices with n-dimensional array * Emphasize importance of discovery and role of collaboration. * Final pass through for wording/grammatical edits. * Added bolded titles to bulleted list in eht casestudy. Addresses comments from review.

For corresponding change in the main repo, see numpy/numpy#16201

Extra space removed Extra space removed

joelachance · 2020-05-12T02:05:37Z

@InessaPawson @rgommers @MarsBarLee ready for another review

joelachance · 2020-05-12T02:07:39Z

Looks like some changes from master might have gotten merged in here, hopefully those don't make this PR too confusing.
I renamed section2 to keyfeatures here to keep things a bit more obvious.

rgommers · 2020-05-12T10:43:27Z

Thanks for the update Joe. The colors and text look good. Could you make the text a link to an empty numpy.org/news (which can come from a news.md)?

There's a lot of whitespace for me and the bar is a bit on the wide side vertically:

rgommers · 2020-05-12T10:45:18Z

Looks like some changes from master might have gotten merged in here, hopefully those don't make this PR too confusing.

Oh yeah that doesn't look too good. I think it's okay for testing for now, I can help do some surgery before merging if needed - I'd prefer not to merge it with this commit history as-is.

joelachance · 2020-05-12T13:44:41Z

agreed-- im not quite sure where that came from, or what it is. i can help remove it if everything else looks good!

rgommers · 2020-05-12T13:56:38Z

Thanks! Yes, the rest of the changes look good to me.

InessaPawson · 2020-05-13T12:43:56Z

Thanks for the update Joe. The colors and text look good. Could you make the text a link to an empty numpy.org/news (which can come from a news.md)?

There's a lot of whitespace for me and the bar is a bit on the wide side vertically:

@rgommers Clearing the cache should fix the whitespace issue. See Joe's tip above!;)

@joelachance The news bar is too wide indeed, let's try min-height: 45px;.

Also, I suggest changing the color of the hero-title font and the background color of the footer to Warm Black ( #013243) to match the rest of the dark elements. (Probably, needs a separate PR.)

These changes should make the top of the homepage look like this:

InessaPawson · 2020-05-13T12:50:21Z

Every time I look at the homepage I can’t help but think that maybe two logos at the top one too many. @joelachance @rgommers @MarsBarLee @shaloo What do you think of removing the smaller logo just from the homepage?

rgommers · 2020-05-13T21:02:44Z

@rgommers Clearing the cache should fix the whitespace issue. See Joe's tip above!;)

Oops, yes that fixes it - thank you both

rgommers · 2020-05-13T21:04:19Z

What do you think of removing the smaller logo just from the homepage?

Dynamically hiding a logo in the header seems a little elaborate. I agree having the double logo is a little odd (but who knows, maybe it looks better with the new logo!). Maybe easier to remove the bigger one?

rgommers · 2020-05-16T13:20:42Z

Rebased and merged in gh-228, with follow-up items noted in the PR description there. Thanks all!

InessaPawson · 2020-05-16T13:21:05Z

Maybe easier to remove the bigger one?

I do like the larger version of the logo next to the title NUMPY. However, if it is the only way to minimize the number of the logos on the homepage, I'm willing to sacrifice it.

rgommers · 2020-05-16T13:26:18Z

Opened gh-229 to track the "remove a logo" todo. Thanks Inessa.

bjnath · 2020-05-17T19:29:54Z

I've just seen the site, and it's breathtaking -- us at our best.

It's so good it has me worried. There's incredible content below the fold --
the ecosystem, the case studies -- and I'm concerned it will not get seen.

I'm wondering how we can get it higher without losing impact. Thoughts:

Omit the KEY FEATURES heading.
The features boxes can be shrunk to links -- or if we want to be fancy,
boxes that expand on mouseover. We will not lose the supporting text; it
will be there for those who want it.
Try NumPy is a tour-de-force -- but we have to ask the hard question of
how much we benefit from having it on page one. The single most important
feature of NumPy is speed, and TryNumpy can't show that. The section is
less pretty and demands active engagement. On a learning page -- it's killer.
It's a beast. It just needs the right home.

joelachance · 2020-05-18T14:17:40Z

Rebased and merged in gh-228, with follow-up items noted in the PR description there. Thanks all!
@rgommers , thank you!

InessaPawson · 2020-05-21T07:10:15Z

Remove the “Key Features” title and “Learn More” below.

@rgommers @joelachance Based on #238 (comment), would you please give a second thought to the quoted suggestion? Keeping it is a waste of prime real estate indeed.

joelachance · 2020-05-21T12:16:56Z

@InessaPawson, I'm a +1 on removing the Key Features title. I'll roll that into existing work here (assuming @rgommers agrees).
I still think a CTA somewhere in the 'key features' section is a good thing (maybe that is the tiles being links to somewhere), but I seem to remember removing the 'learn more' already (it's probably in a branch in progress, if it's not in master). I'll do that as well, pending comments from @rgommers

rgommers · 2020-05-21T16:11:05Z

Sounds like you all agree, it seems fine with me too, the tiles will work standalone too - please go for it!

moves shell into partial and moves below key features. Adds numpy she…

c8dbb3a

…l title

joelachance requested review from rgommers, InessaPawson and MarsBarLee April 24, 2020 02:00

adds a news section, no news content

d051b98

InessaPawson requested changes Apr 24, 2020

View reviewed changes

rgommers added the design label Apr 25, 2020

Ref #gh_164 First draft of Cricket analytics using NumPy (#174)

ad8334d

InessaPawson mentioned this pull request Apr 28, 2020

Adds a news section #222

Merged

InessaPawson mentioned this pull request Apr 30, 2020

Add News Section #219

Closed

shaloo and others added 6 commits May 8, 2020 19:16

Enhanced scripts to generate numpy dependency graph for various pkg

c57fa66

Fixes #217 with gwpy and PyCBC dependency graphs plus updated scripts…

ba28327

… to generate the same

Ref #gh-182, fixes #gh-217 review comments addressed

140823a

Cleanup of README, 80char line Cleanup of README, 80char line

DOC: update members of the CoC committee

632bb7f

For corresponding change in the main repo, see numpy/numpy#16201

Fixes minor typos and grammar ref pull request 174

203cdcb

Extra space removed Extra space removed

joelachance added 5 commits May 11, 2020 20:36

merging news changes

1df60a0

removes numpy shell title

5a4d365

renames section2 to keyfeatures

f5b8600

removing the CTA on key features section

29116f3

adds first news section, adds news styles, removes hero footer (empty)

19347b3

joelachance requested a review from InessaPawson May 12, 2020 02:05

InessaPawson mentioned this pull request May 13, 2020

NumPy logo refresh #37

Closed

rgommers mentioned this pull request May 16, 2020

Moves shell below key features #228

Merged

rgommers closed this May 16, 2020

rgommers mentioned this pull request May 16, 2020

Remove one of the two logos at the top of the front page #229

Closed

bjnath mentioned this pull request May 17, 2020

Where to go after "Get started" #233

Open

rgommers deleted the feature/220-move-shell branch August 30, 2020 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Moves shell below key features #221

Moves shell below key features #221

joelachance commented Apr 24, 2020

InessaPawson left a comment

joelachance commented Apr 24, 2020

InessaPawson commented Apr 25, 2020

rgommers commented Apr 25, 2020

InessaPawson commented Apr 26, 2020 •

edited

Loading

InessaPawson commented Apr 28, 2020

joelachance commented Apr 28, 2020

rgommers commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

joelachance commented Apr 30, 2020

InessaPawson commented May 1, 2020

rossbar commented May 4, 2020

InessaPawson commented May 5, 2020

joelachance commented May 12, 2020

joelachance commented May 12, 2020

rgommers commented May 12, 2020

rgommers commented May 12, 2020

joelachance commented May 12, 2020

rgommers commented May 12, 2020

InessaPawson commented May 13, 2020

InessaPawson commented May 13, 2020

rgommers commented May 13, 2020

rgommers commented May 13, 2020

rgommers commented May 16, 2020

InessaPawson commented May 16, 2020

rgommers commented May 16, 2020

bjnath commented May 17, 2020 •

edited

Loading

joelachance commented May 18, 2020

InessaPawson commented May 21, 2020

joelachance commented May 21, 2020

rgommers commented May 21, 2020

Moves shell below key features #221

Moves shell below key features #221

Conversation

joelachance commented Apr 24, 2020

InessaPawson left a comment

Choose a reason for hiding this comment

joelachance commented Apr 24, 2020

InessaPawson commented Apr 25, 2020

rgommers commented Apr 25, 2020

InessaPawson commented Apr 26, 2020 • edited Loading

InessaPawson commented Apr 28, 2020

joelachance commented Apr 28, 2020

rgommers commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

InessaPawson commented Apr 30, 2020

joelachance commented Apr 30, 2020

InessaPawson commented May 1, 2020

rossbar commented May 4, 2020

InessaPawson commented May 5, 2020

joelachance commented May 12, 2020

joelachance commented May 12, 2020

rgommers commented May 12, 2020

rgommers commented May 12, 2020

joelachance commented May 12, 2020

rgommers commented May 12, 2020

InessaPawson commented May 13, 2020

InessaPawson commented May 13, 2020

rgommers commented May 13, 2020

rgommers commented May 13, 2020

rgommers commented May 16, 2020

InessaPawson commented May 16, 2020

rgommers commented May 16, 2020

bjnath commented May 17, 2020 • edited Loading

joelachance commented May 18, 2020

InessaPawson commented May 21, 2020

joelachance commented May 21, 2020

rgommers commented May 21, 2020

InessaPawson commented Apr 26, 2020 •

edited

Loading

bjnath commented May 17, 2020 •

edited

Loading