Ref #gh_164 First draft of Cricket analytics using NumPy #174

shaloo · 2020-03-09T04:41:00Z

Finally, managed to correct my fork. It is now synced up with NumPy/numpy.org. Here is the first draft of the cricket sports analytics case study.

Brief description of what is fixed or changed

Deployed URL

http://numpy-174.surge.sh/

matthew-brett · 2020-03-09T09:29:35Z

Very glad to see this - thanks!

rgommers

Thanks @shaloo! This reads well overall. I wonder if it's a little too text-heavy at the start, perhaps a few sentences can be trimmed - I made one concrete suggestion about the money part, there may be a couple of other options.

You identified a good number of usages of NumPy in blog posts. I remember there was a package as well previously, but it was a little light. I wonder if there's some other package, or maybe a professional sports analytics firm that could provide a testimonial or insight in their NumPy usage?

Submitting the few comments I have. Could you break lines to <80 chars? Then it's easier to comment on textual things.

content/en/case-studies/cricket-analytics.md

shaloo · 2020-03-15T06:41:51Z

Thanks @shaloo! This reads well overall. I wonder if it's a little too text-heavy at the start, perhaps a few sentences can be trimmed - I made one concrete suggestion about the money part, there may be a couple of other options.

You identified a good number of usages of NumPy in blog posts. I remember there was a package as well previously, but it was a little light. I wonder if there's some other package, or maybe a professional sports analytics firm that could provide a testimonial or insight in their NumPy usage?

Submitting the few comments I have. Could you break lines to <80 chars? Then it's easier to comment on textual things.

Line width updated to 80/100 chars. Clipped out extra text at the start.

shaloo · 2020-03-15T07:24:59Z

Ralf, should we add this case study draft for the first website release? That will help us get attention from folks / news media/ sports entertainment enthusiasts to contribute and give us more details / point out inaccuracies wrt NumPy usage in Cricket Analytics? So far, I have approached several folks who are connected to the game but haven't figured a NumPy link yet. Have sent out some gentle reminders again today.
The data presented in this case study is based on publicly available information and we need some deeper insights from those who actually have used NumPy for cricket. They may not be on NumPy contributor list as of now so we need to increase the visibility I think.

rgommers · 2020-03-22T18:06:25Z

Ralf, should we add this case study draft for the first website release? T

Yes, I'd like to include it!

I rebased, did a copy-edit of the whole text, and fixes some figure captions and attributions. Will comment on some issues within a couple of hours.

rgommers

I think the topic an imagery are both quite nice. Main takes on the content:

The About Cricket section flows well.
Key Data Analytics Objectives could be tweaked slightly to focus more on the objectives, however it's already a good section.
In The Challenges there is too much text, and I'm not sure "Data Representation" is really one of the main challenges because if "Data cleaning and preprocessing" is done well then the representation will be okay.
NumPy’s Role in Cricket Analytics there's significant cross-talk between the three bullets. For example the first bullet discusses "graphing and visualization", while the third bullet has "data visualization" as a heading.
Summary text looks good. In the image I'd like to remove "data correlation", because that's not a "key capability" of NumPy.

rgommers · 2020-03-22T18:59:46Z

content/en/case-studies/cricket-analytics.md

+<blockquote cite="https://www.scoopwhoop.com/sports/ms-dhoni/">
+    <p>You don't play for the crowd, you play for the country.</p>
+    <footer align="right">—M S Dhoni, <cite>International Cricket Player, ex-captain, Indian Team, plays for Chennai Super Kings in IPL</cite></footer>
+</blockquote>


It could be nice to replace this with a quote related to NumPy. I think of all the links in this case study, the Stats LLC one looks most substantial. @shaloo have you tried contacting http://patricklucey.com/index.html ?

Initiated email conversation regarding the same.

Waiting on email response. We can update it once I get more insights from Patrick later as a new / fresh PR. May be we can close this one and open a new issue once I hear from Patrick.

Ralf, can we merge cricket case study updates now? I haven't heard back from most of those who I contacted regarding this, Patrick included. Once it shows up on the site, there will be more takers to provide feedback or better conten, I think.

content/en/case-studies/cricket-analytics.md

rgommers · 2020-03-28T17:09:22Z

@shaloo I think I would give the case studies priority over the team page right now, since there'll be more review and changes needed for this PR than the team gallery one.

shaloo · 2020-03-29T15:54:13Z

sure, will get this in right away.

rgommers

This is looking pretty good now, one comment left. NumPy key benefits of "speed" and "numerical analysis" are the right ones I think.

content/en/case-studies/cricket-analytics.md

Also fixes a number of issues with image credits, and changes the styling of those credits in captions. Alt text is also improved.

Removing capitalization and a few textual things.

…to it

rgommers · 2020-04-26T20:01:48Z

Merged, thanks Shaloo!

anirudh2290

Thanks @shaloo for this nice writeup. Overall looks good, I have added some small observations.

content/en/case-studies/cricket-analytics.md

anirudh2290 · 2020-04-29T22:42:41Z

content/en/case-studies/cricket-analytics.md

+  are used for tactical analysis.
+
+* **Data Visualization:** Data graphing and [visualization](https://towardsdatascience.com/advanced-sports-visualization-with-pandas-matplotlib-and-seaborn-9c16df80a81b)
+  provides useful insights into relationship between various datasets.


although these two points make sense in general for how numpy will be used in cricket analytics and i am sure numpy is used in cricket linked sporting analysis, the linked articles aren't specific to cricket. maybe its the case that we dont have concrete examples today ?

That's correct. I have been chasing a few folks from the cricketing analytics world but haven't been able to get these inputs yet. Would you have any leads / insights into the same?

anirudh2290 · 2020-04-29T22:44:21Z

content/en/case-studies/cricket-analytics.md

+and other PyData packages like Scikit-learn, SciPy, Matplotlib, and Jupyter.
+in addition to latest machine learning and AI techniques.  NumPy has been used


nit:
, after Jupter instead of .

anirudh2290 · 2020-04-29T22:49:00Z

content/en/case-studies/cricket-analytics.md

+
+## Summary
+
+Sports Analytics have changed the way professional games are played, especially


should it read : "Sport Analytics has changed the way professional games are played" instead ?

shaloo · 2020-05-07T07:26:36Z

Thanks @shaloo for this nice writeup. Overall looks good, I have added some small observations.

Thank you Anirudh, appreciate your inputs!

rgommers · 2020-05-11T14:48:13Z

Thanks for the review @anirudh2290. Fixes were made in gh-226 (merged).

shaloo requested review from rgommers, InessaPawson and MarsBarLee March 9, 2020 04:41

rgommers added the content label Mar 10, 2020

rgommers reviewed Mar 10, 2020

View reviewed changes

content/en/case-studies/cricket-analytics.md Outdated Show resolved Hide resolved

content/en/case-studies/cricket-analytics.md Outdated Show resolved Hide resolved

rgommers force-pushed the sfork-issu-164 branch from fc81b39 to aa008f8 Compare March 22, 2020 16:06

rgommers force-pushed the sfork-issu-164 branch from 601eefa to c23c49a Compare March 22, 2020 18:46

rgommers reviewed Mar 22, 2020

View reviewed changes

content/en/case-studies/cricket-analytics.md Outdated Show resolved Hide resolved

rgommers force-pushed the sfork-issu-164 branch from 8bc97b2 to 09e9de9 Compare March 22, 2020 20:46

shaloo requested a review from rgommers March 29, 2020 17:44

rgommers force-pushed the sfork-issu-164 branch from a178889 to d583d26 Compare March 30, 2020 16:43

rgommers reviewed Mar 30, 2020

View reviewed changes

content/en/case-studies/cricket-analytics.md Outdated Show resolved Hide resolved

shaloo and others added 8 commits April 23, 2020 09:39

Ref #gh_164 First draft of Cricket analytics using NumPy

d3813c1

Missed the home page link update, done now

143b16b

Fixes Review comments for #gh_164

47438ba

Fix styling of image credits

72e00d7

A copy-edit of the cricket analytics case study.

00bae50

Also fixes a number of issues with image credits, and changes the styling of those credits in captions. Alt text is also improved.

Minor tweak to text on cricket analytics tile on front page.

d11b4dd

Removing capitalization and a few textual things.

Fixes #numpygh-164 addresses Ralf's comments in PR

514ac0d

Line breaks to <80 char in cricket case study

3a37239

shaloo force-pushed the sfork-issu-164 branch from d583d26 to 3a37239 Compare April 23, 2020 04:09

Address last comment, move up "statistical analysis" and add content …

39ad413

…to it

rgommers merged commit ad8334d into numpy:master Apr 26, 2020

anirudh2290 reviewed Apr 29, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ref #gh_164 First draft of Cricket analytics using NumPy #174

Ref #gh_164 First draft of Cricket analytics using NumPy #174

shaloo commented Mar 9, 2020 •

edited

Loading

matthew-brett commented Mar 9, 2020

rgommers left a comment

shaloo commented Mar 15, 2020 •

edited

Loading

shaloo commented Mar 15, 2020 •

edited

Loading

rgommers commented Mar 22, 2020

rgommers left a comment

rgommers Mar 22, 2020

shaloo Mar 29, 2020

shaloo Mar 29, 2020

shaloo Apr 23, 2020

rgommers commented Mar 28, 2020

shaloo commented Mar 29, 2020

rgommers left a comment

rgommers commented Apr 26, 2020

anirudh2290 left a comment

anirudh2290 Apr 29, 2020

shaloo May 7, 2020

anirudh2290 Apr 29, 2020

anirudh2290 Apr 29, 2020

shaloo commented May 7, 2020

rgommers commented May 11, 2020

		and other PyData packages like Scikit-learn, SciPy, Matplotlib, and Jupyter.
		in addition to latest machine learning and AI techniques. NumPy has been used


		## Summary

		Sports Analytics have changed the way professional games are played, especially

Ref #gh_164 First draft of Cricket analytics using NumPy #174

Ref #gh_164 First draft of Cricket analytics using NumPy #174

Conversation

shaloo commented Mar 9, 2020 • edited Loading

Brief description of what is fixed or changed

Deployed URL

matthew-brett commented Mar 9, 2020

rgommers left a comment

Choose a reason for hiding this comment

shaloo commented Mar 15, 2020 • edited Loading

shaloo commented Mar 15, 2020 • edited Loading

rgommers commented Mar 22, 2020

rgommers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgommers commented Mar 28, 2020

shaloo commented Mar 29, 2020

rgommers left a comment

Choose a reason for hiding this comment

rgommers commented Apr 26, 2020

anirudh2290 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaloo commented May 7, 2020

rgommers commented May 11, 2020

shaloo commented Mar 9, 2020 •

edited

Loading

shaloo commented Mar 15, 2020 •

edited

Loading

shaloo commented Mar 15, 2020 •

edited

Loading