Skip to content

Remove one of the two logos at the top of the front page #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgommers opened this issue May 16, 2020 · 4 comments
Closed

Remove one of the two logos at the top of the front page #229

rgommers opened this issue May 16, 2020 · 4 comments
Assignees
Labels

Comments

@rgommers
Copy link
Member

As discussion on gh-221, there are now two logos on the front page. Discussion:

What do you think of removing the smaller logo just from the homepage?

Dynamically hiding a logo in the header seems a little elaborate. I agree having the double logo is a little odd (but who knows, maybe it looks better with the new logo!). Maybe easier to remove the bigger one?

I do like the larger version of the logo next to the title NUMPY. However, if it is the only way to minimize the number of the logos on the homepage, I'm willing to sacrifice it.

@joelachance
Copy link
Collaborator

My preference would be to remove the logo in the nav bar and keep the 'exponential' logo with the NumPy title, until the user scrolls down (nav bar logo shows after user scrolls).

There's potential that's the harder fix (although we may need to simply remove the logo config from the nav partial), and if other people prefer the other option of removing the exponential logo, then I'm game!

@rgommers
Copy link
Member Author

I'm happy with removing the navbar logo unconditionally.

@InessaPawson
Copy link
Member

My preference would be to remove the logo in the nav bar and keep the 'exponential' logo with the NumPy title, until the user scrolls down (nav bar logo shows after user scrolls).

+1 for the above. I thought there was a way!;) Thank you, @joelachance!

@joelachance joelachance self-assigned this May 20, 2020
@rgommers
Copy link
Member Author

We merged the PR for this, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants