Skip to content

Bug/mobile css #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2020
Merged

Bug/mobile css #255

merged 5 commits into from
May 23, 2020

Conversation

joelachance
Copy link
Collaborator

Resolves #227, #229
Removes Key Features title.

@InessaPawson
Copy link
Member

Good job, @joelachance!
One minor fix is needed: the news bar is missing a link on this branch.

@rgommers
Copy link
Member

rgommers commented May 22, 2020

One minor fix is needed: the news bar is missing a link on this branch.

This is already fixed in master and unrelated to this PR. If you're checking out this branch and want to see exactly what it looks like after merge, you have to rebase on master locally - then you'll see the news links in this case.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joelachance, mostly LGTM. There's one issue: removing the logo from the fixed navbar on all pages makes it impossible to navigate back to the home page (e.g. try Install, you can't even scroll down there so the logo will never appear). That turns a style issue into a usability issue, so better not to do that. Is it possible to hide the logo only on the front page?

@joelachance
Copy link
Collaborator Author

Yep, good catch, @rgommers!

@InessaPawson
Copy link
Member

That turns a style issue into a usability issue, so better not to do that. Is it possible to hide the logo only on the front page?

Good catch, @rgommers! Great job, @joelachance! I'm very happy with this edit.

@rgommers rgommers merged commit bd8ea37 into master May 23, 2020
@rgommers rgommers deleted the bug/mobile-css branch May 23, 2020 13:15
@rgommers
Copy link
Member

LGTM too now, merged. Thanks Joe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc Mobile rendering issues and CSS suggestions
3 participants