-
-
Notifications
You must be signed in to change notification settings - Fork 120
Bug/mobile css #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/mobile css #255
Conversation
Good job, @joelachance! |
This is already fixed in master and unrelated to this PR. If you're checking out this branch and want to see exactly what it looks like after merge, you have to rebase on master locally - then you'll see the news links in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joelachance, mostly LGTM. There's one issue: removing the logo from the fixed navbar on all pages makes it impossible to navigate back to the home page (e.g. try Install
, you can't even scroll down there so the logo will never appear). That turns a style issue into a usability issue, so better not to do that. Is it possible to hide the logo only on the front page?
Yep, good catch, @rgommers! |
Good catch, @rgommers! Great job, @joelachance! I'm very happy with this edit. |
LGTM too now, merged. Thanks Joe! |
Resolves #227, #229
Removes Key Features title.