Skip to content

Misc Mobile rendering issues and CSS suggestions #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Carreau opened this issue May 13, 2020 · 2 comments · Fixed by #255
Closed

Misc Mobile rendering issues and CSS suggestions #227

Carreau opened this issue May 13, 2020 · 2 comments · Fixed by #255
Assignees
Labels

Comments

@Carreau
Copy link

Carreau commented May 13, 2020

The shell-content wiht blocks of code make the website rendering looks weird on mobile

.shell-content {
    min-width: 500px;
}

Seem to interfere wit mobile rendering issue by forcing the page to be too wide, which lead to while gap on the left:

Before/After removing the 500px min width
Screen Shot 2020-05-13 at 10 00 00
Screen Shot 2020-05-13 at 10 00 07

Can't be completely removed as the code blocks become unreadable, but I'm guessing those can be tweaked with media-screen queries

also:

.section3-box-content {
    margin: 30px 30px 30px 0;
}

Screen Shot 2020-05-13 at 10 03 28

Is not centered on mobile view either. 30px on all side is likely what you want on small screen (via media queries as well?).

.section2 seem to have the same issue but less visible.

There also seem to be a few screen width transition that are either off by one pixel between files or used only once:

// syle.css

// only transition at at 320
@media only screen and (max-width: 320px) { 

// syle.css only transition at at 400
@media only screen and (max-width: 400px) {

// section2.css only transition at at 420
@media only screen and (max-width: 425px) {
    .section2 .container {

Both of the following transition are off by 1px or 2px from the one in the theme used (bulma) and might lead to edge case behavior.

// contents.css
@media only screen and (max-width: 1088px) {
    .shortcuts-container {
        display: none;
    }
}
// section2.css
@media only screen and (max-width: 1090px) {
    .section2 .container {
        margin: 0 6vw;
    }
}

Chrome says there are transitions at 1087px,1088px, and 1090px maybe all those values should be collapsed ? Usually the less transitions the better has you have less screen width to test for rendering issues. These off-by-one are common even in framework as it is rarely clear in min-screen-width/max-screen-width if the end value is included or not.

New website looks great otherwise will try to review a content and give feedback ! Good work !

@joelachance
Copy link
Collaborator

@Carreau Thank you for the feedback! We'll take a look.

@joelachance joelachance self-assigned this May 19, 2020
@joelachance
Copy link
Collaborator

I'm finding that our Hugo theme is contributing a good amount to the media-query pollution, cleaned that up as much as possible.

@Carreau , thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants