Skip to content

Adds a news section #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

Adds a news section #222

merged 1 commit into from
May 12, 2020

Conversation

joelachance
Copy link
Collaborator

Resolves #219.

@InessaPawson, I wasn't sure about layout here. Do you have an example we should emulate?
I'm assuming we might tackle content in another ticket.

@InessaPawson
Copy link
Member

@InessaPawson, I wasn't sure about layout here. Do you have an example we should emulate?

@joelachance I quite like the news section here: https://kotlinlang.org, which is a .svg linking to a news article. We won't be linking to anything for now.

I'm assuming we might tackle content in another ticket.

Yes, I’ll take care of the content/image in a separate PR.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joelachance! Just checking, is the smaller font and not all-uppercase on purpose here?

image

@InessaPawson
Copy link
Member

Thanks @joelachance! Just checking, is the smaller font and not all-uppercase on purpose here?

@rgommers It's just a placeholder, none of it will show. I’ll submit a PR with an image shortly.

@joelachance
Copy link
Collaborator Author

@rgommers, @InessaPawson is correct, simply a placeholder. If we keep the title, we can uppercase it with: text-transform: uppercase;

@InessaPawson
Copy link
Member

Just an image for now:

numpynews_warmblack

This is how it looks in a prototype: #221 (comment)

@rgommers I need your input for the content of this section. Once everything is confirmed, I'll create a .svg version and submit a PR.

@InessaPawson InessaPawson mentioned this pull request Apr 30, 2020
@joelachance
Copy link
Collaborator Author

Merging here, continuing work on PR #221.

@joelachance joelachance merged commit 2721953 into master May 12, 2020
@joelachance joelachance deleted the feature/219-news-section branch May 12, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add News Section
3 participants