Skip to content

Support elasticsearch-dsl > 6.1.0 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
piedrahitapablo opened this issue Jul 5, 2018 · 6 comments · Fixed by #136
Closed

Support elasticsearch-dsl > 6.1.0 #115

piedrahitapablo opened this issue Jul 5, 2018 · 6 comments · Fixed by #136
Labels
bug

Comments

@piedrahitapablo
Copy link

piedrahitapablo commented Jul 5, 2018 •
edited
Loading

I am not sure about this issue but django-elasticsearch-dsl does not work with elasticsearch-dsl versions higher than 6.1.0, it shows an import error for DocType and DocTypeMeta, apparently they were removed in newer versions of elasticsearch-dsl.
@sulami
Copy link

sulami commented Jul 5, 2018

See elastic/elasticsearch-dsl-py#930

@matali1
Copy link

matali1 commented Jul 6, 2018

elastic/elasticsearch-dsl-py#930 fixed problem with DocType but not DocTypeMeta so new version 6.2.1 still doesn't work

@dsanders11 dsanders11 mentioned this issue Jul 7, 2018
Merged
This was referenced Jul 25, 2018
Closed
Closed
@safwanrahman safwanrahman changed the title Does not work with elasticsearch-dsl > 6.1.0 Support elasticsearch-dsl > 6.1.0 Sep 21, 2018
@safwanrahman
Copy link
Collaborator

This package was using an internal undocumented Metaclass of elasticsearch-dsl. I am working on a patch to not use the internal undocumented metaclass so its possible to use the latest version of elasticsearch-dsl

@matthiaskoenig matthiaskoenig mentioned this issue Oct 20, 2018
Closed
@lthibault
Copy link

@safwanrahman Any word on this? Do you have an ETA?

@safwanrahman
Copy link
Collaborator

@lthibault Sorry for the delay. I went to Elasticsearch Engineering II training and traveling.
I have been working on this quite some days, but the changes are architectural changes are they are so big that its not getting there! 😞
I am hoping to finish it, but I can not promise for any ETA! sorry

@lthibault
Copy link

@safwanrahman No worries! Happy to hear someone is taking care of it 😃
Good luck with the major refactor -- we've all been there!

@safwanrahman safwanrahman mentioned this issue Nov 6, 2018
Merged
sabricot added a commit that referenced this issue Nov 7, 2018
@sabricot
Update elasticsearch-dsl requirement
c1b6aa6 
Due to some changes in elasticsearch-dsl we don't
support elasticsearch-dsl > 6.1 yet.

See issue #115
@andriilahuta andriilahuta mentioned this issue Apr 30, 2019
Closed
safwanrahman added a commit that referenced this issue Jun 1, 2019
@safwanrahman
Merge pull request #136 from safwanrahman/major_fix
8b10611 
[Fix #115] Support elasticsearch-dsl > 6.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #115] Support elasticsearch-dsl > 6.1.0 safwanrahman/django-elasticsearch-dsl
5 participants
@sulami @piedrahitapablo @safwanrahman @lthibault @matali1