-
Notifications
You must be signed in to change notification settings - Fork 268
[Fix #115] Support elasticsearch-dsl > 6.1.0 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @safwanrahman for your contribution i didn't have yet looked at it, but i promise i will soon. |
@kornikopic Thanks for going through the changes. I have been working on this PR and still not finished. |
This PR depends on elastic/elasticsearch-dsl-py#1099 |
After all, it passed all the tests and working perfectly! 💯 @sabricot can you take a look into it? |
e6c5fe3
to
7a85187
Compare
Is this going to be merged eventually? |
@SeguinBe This was blocked for elastic/elasticsearch-dsl-py#1099. As the blocking PR has been merged recently, I think we can merge this PR soon. |
I can not find any people to review this PR. So going to merge it! |
This does not work!Its something like verification purpose. The test are not passing!
need documentation fix and others.
Do not try this still!
this fixes #115