Skip to content

[Fix #115] Support elasticsearch-dsl > 6.1.0 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 1, 2019

Conversation

safwanrahman
Copy link
Collaborator

@safwanrahman safwanrahman commented Nov 6, 2018

This does not work!
Its something like verification purpose. The test are not passing!
need documentation fix and others.
Do not try this still!

this fixes #115

@sabricot
Copy link
Member

sabricot commented Nov 7, 2018

Thank you @safwanrahman for your contribution i didn't have yet looked at it, but i promise i will soon.

@safwanrahman
Copy link
Collaborator Author

@kornikopic Thanks for going through the changes. I have been working on this PR and still not finished.
I will remove the debugging codes when I finish the PR, but for debugging purpose, its necessary actually.

@safwanrahman
Copy link
Collaborator Author

This PR depends on elastic/elasticsearch-dsl-py#1099

@safwanrahman
Copy link
Collaborator Author

After all, it passed all the tests and working perfectly! 💯
Now needs couple of cleanup and a rebase and it will be ready for review! 🚀
Moreover, need some documentation also!

@sabricot can you take a look into it?

@safwanrahman safwanrahman changed the title [WIP] [Fix #115] Support elasticsearch-dsl > 6.1.0 [Fix #115] Support elasticsearch-dsl > 6.1.0 Jan 26, 2019
@SeguinBe
Copy link

SeguinBe commented May 9, 2019

Is this going to be merged eventually?

@safwanrahman
Copy link
Collaborator Author

Is this going to be merged eventually?

@SeguinBe This was blocked for elastic/elasticsearch-dsl-py#1099. As the blocking PR has been merged recently, I think we can merge this PR soon.
Anyone is up there for reviewing the PR? @sabricot will you have some time?

@safwanrahman
Copy link
Collaborator Author

I can not find any people to review this PR. So going to merge it!

@safwanrahman safwanrahman merged commit 8b10611 into django-es:master Jun 1, 2019
@alaminopu alaminopu mentioned this pull request Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support elasticsearch-dsl > 6.1.0
4 participants