-
Notifications
You must be signed in to change notification settings - Fork 267
Elasticsearch 7 support #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stylemistake, thanks, but I don't deserve the credit here. Most of the work was done in #136, which my fork is based on. I just removed the mapping types and added a few utility functions. |
As one of the contributor of this project and sole contributor of #136, which this fork is based on, I think your comment is disrespectful to the maintainer of this project. You should show empathy towards the maintainers who are giving their time for this project. |
All I wanted to say is that until this is merged to master, there will be people who just look for a working library, and this branch is a good place to start because it contains all relevant merges and changes that make it all work. I am by no means devaluing the work you've done here. |
Thanks for the issue @laevilgenius . I have started working on this in #176. Can you suggest some changes that you made in your fork? |
@safwanrahman, here's the diff. It's pretty straightforward: I removed mapping types and made code compatible with elasticsearch-dsl>=7.0.0. I also fixed an issue with tests not deleting test indices, although I'm still not sure it works every time. Plus I added a couple of utility functions which I find quite useful, but I have already submitted them as PRs. |
@safwanrahman Great work on #115 👏🏽👏🏽. Are we close to getting #176 merged as well? |
[Fix #170] Support Elasticsearch 7.x
This depends on #115, although a few more changes are required, the most notable being the removal of mapping types.
To make things easier, perhaps it makes sense to mimic
elasticsearch-dsl
versioning scheme?The text was updated successfully, but these errors were encountered: