Skip to content

Elasticsearch 7 support #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andriilahuta opened this issue Apr 30, 2019 · 6 comments · Fixed by #176
Closed

Elasticsearch 7 support #170

andriilahuta opened this issue Apr 30, 2019 · 6 comments · Fixed by #176

Comments

@andriilahuta
Copy link
Contributor

This depends on #115, although a few more changes are required, the most notable being the removal of mapping types.
To make things easier, perhaps it makes sense to mimic elasticsearch-dsl versioning scheme?

@andriilahuta
Copy link
Contributor Author

@stylemistake, thanks, but I don't deserve the credit here. Most of the work was done in #136, which my fork is based on. I just removed the mapping types and added a few utility functions.

@safwanrahman
Copy link
Collaborator

safwanrahman commented May 23, 2019

Although it is still a work in progress, it works like a charm. If author is not going to provide any updates, I suggest y'all consider this fork as a new upstream.

As one of the contributor of this project and sole contributor of #136, which this fork is based on, I think your comment is disrespectful to the maintainer of this project. You should show empathy towards the maintainers who are giving their time for this project.

@stylemistake
Copy link

stylemistake commented May 23, 2019

All I wanted to say is that until this is merged to master, there will be people who just look for a working library, and this branch is a good place to start because it contains all relevant merges and changes that make it all work.

I am by no means devaluing the work you've done here.

@safwanrahman
Copy link
Collaborator

Thanks for the issue @laevilgenius . I have started working on this in #176. Can you suggest some changes that you made in your fork?

@andriilahuta
Copy link
Contributor Author

@safwanrahman, here's the diff. It's pretty straightforward: I removed mapping types and made code compatible with elasticsearch-dsl>=7.0.0. I also fixed an issue with tests not deleting test indices, although I'm still not sure it works every time.

Plus I added a couple of utility functions which I find quite useful, but I have already submitted them as PRs.

@CorrosiveKid
Copy link
Contributor

@safwanrahman Great work on #115 👏🏽👏🏽. Are we close to getting #176 merged as well?

safwanrahman added a commit that referenced this issue Aug 10, 2019
[Fix  #170] Support Elasticsearch 7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants