Skip to content

Restores old DocType interface #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Conversation

0bsearch
Copy link
Contributor

@0bsearch 0bsearch commented Jul 3, 2018

DocType was refactored to Document, DocType as class was added to backaward compat, but its missing from high-level interface.
@honzakral from elasticsearch_dsl import DocType is broken in latest PyPI release (6.2.0). Taking into account that this is minor one, I guess, this should be merged and re-uploaded to PyPI asap.

@honzakral
Copy link
Contributor

Thanks, good catch! I will add it to the planned 6.2.1 release with #929

@0bsearch
Copy link
Contributor Author

0bsearch commented Jul 3, 2018

Thanks. Any ETA on this? I mean, for 6.2.1 publish?

@honzakral
Copy link
Contributor

I am hoping for later today, unfortunately cannot do it right now, but by EOD today (CEST). Sorry for the inconvenience

@honzakral honzakral merged commit a307585 into elastic:master Jul 3, 2018
@honzakral
Copy link
Contributor

6.2.1 is out, thanks again for the quick patch!

@GeorgeLubaretsi
Copy link

I think it makes sense to add DocTypeMeta compatibility as well

@honzakral
Copy link
Contributor

@GeorgeLubaretsi in what way? That was never really considered public api and is no longer around, what is the use case for it?

@GeorgeLubaretsi
Copy link

DocTypeMeta is used in django-elasticsearch-dsl for registering and mapping ORM models to ES documents.

On a second thought, I guess this should be resolved in django-elasticsearch-dsl if this was never a public API.

@honzakral
Copy link
Contributor

It should definitely be resolved there. I would be happy to help if there are some additional hooks or anything needed in elasticsearch-dsl, just open an issue or a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants