Skip to content

CI clearup #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 24, 2022
Merged

CI clearup #83

merged 8 commits into from
Jan 24, 2022

Conversation

honno
Copy link
Member

@honno honno commented Jan 21, 2022 •
edited
Loading

Resolves #49 by using the --ci flag introduced in #80 and updating the xfails, pinning to numpy=1.22.1.

  • Fixed a fair few minor bugs found along the way
  • Resolves Test type promotion in elementwise/operator tests #64 so CI actually covers type promotion for elwise/operators
  • Deletes the stubs workflow for now, as we need to rework that anyway once the RST conversion is done so getting CI failures isn't useful
    • (for another PR) Add pytest.mark.ci to the special case tests
  • For the NumPy workflow, xfails linalg tests for now as I'm not sure where we're at with them. I'll probably get up to speed next week and see what needs to be done

honno added 8 commits January 21, 2022 14:25
@honno
Fix test_meshgrid generating multiple dtypes
dd83d68
@honno
Update conftest.py for the mark.primary -> mark.ci change
33505a7
@honno
Fix test_setitem_masking using wrong instance check for py3.8
000d0f9
@honno
Remove stubs workflow for now
0f2ef0a 
We need to update `generate_stubs.py` and probably wait for the 2021 spec
release, so it's not worth worrying about this workflow for now.
@honno
Update div-related testing with spec changes
05b96ae
@honno
test_duck_typing -> test_scalar_casting
0639379 
Duck typing is the incorrect terminology here
@honno
Update NumPy workflow
f0264cc
@honno
Test dtypes in test_operators_and_elementwise_functions.py
4d1b333 
Also standardises use of `out` variable name, except using `res` when an
in-place operation may take place.
@honno honno marked this pull request as ready for review January 21, 2022 18:07
@honno honno requested a review from asmeurer January 21, 2022 18:07
@honno honno merged commit 693c29b into data-apis:master Jan 24, 2022
@honno honno deleted the ci-clearup branch February 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmeurer asmeurer Awaiting requested review from asmeurer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test type promotion in elementwise/operator tests Clear up CI
1 participant
@honno