Skip to content

Test type promotion in elementwise/operator tests #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
honno opened this issue Jan 6, 2022 · 0 comments · Fixed by #83
Closed

Test type promotion in elementwise/operator tests #64

honno opened this issue Jan 6, 2022 · 0 comments · Fixed by #83
Labels
high priority High-priority issue

Comments

@honno
Copy link
Member

honno commented Jan 6, 2022

@asmeurer has already said to me that he found the granular type promotion tests useful when developing numpy.array_api, but I think it'd be nice if the primary tests also did this anyway.

  • An implementer might rely on the primary test when developing an elwise/op function, so end up missing the type promotion errors.
  • xfailing test_type_promotion.py tests is annoying by way of how it parametrizes (e.g. I'm finding this for Clear up CI #49), so it'd be nice if we could have a CI job that only runs the primary tests (as they should implicitly cover the type promotion and signature tests).
This was referenced Jan 18, 2022
@honno honno added the high priority High-priority issue label Jan 21, 2022
@honno honno mentioned this issue Jan 21, 2022
1 task
@honno honno closed this as completed in #83 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High-priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant