Skip to content

Clear up CI #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
honno opened this issue Dec 10, 2021 · 3 comments · Fixed by #83
Closed
3 tasks

Clear up CI #49

honno opened this issue Dec 10, 2021 · 3 comments · Fixed by #83
Assignees
Labels
high priority High-priority issue

Comments

@honno
Copy link
Member

honno commented Dec 10, 2021

IMO it's not worth touching CI as the 1st spec release is so close as well as NumPy, but here's an issue to keep us accountable when time time comes :) well it's 2022 now so

  • Update stubs
    • Create a custom pre-commit hook to check/fix outdated stubs (done something similar)
  • Identify remaining tests to xfail for the NumPy job
@asmeurer
Copy link
Member

I wouldn't make the stubs required to commit. The problem is that sometimes the generate script needs to be updated first.

@honno
Copy link
Member Author

honno commented Dec 13, 2021

I wouldn't make the stubs required to commit. The problem is that sometimes the generate script needs to be updated first.

Ah I don't mean you need to always commit the stubs, but that a hook will check when you need to update them (and thus commit). This could first check whether your local spec is up-to-date. Things might be slow but some quick checks and simple caching should soothe things. I think this would save us a lot of pain down the road in regards to CI failing.

(and defo a pre-commit hook is not a big priority)

@honno honno self-assigned this Jan 3, 2022
@honno honno added the high priority High-priority issue label Jan 18, 2022
@honno
Copy link
Member Author

honno commented Jan 18, 2022

RE NumPy workflow: I think I will resolve #64 and make a pytest marker that just runs "primary" tests, as that makes writing workflows much easier. We can pin on released versions now i.e. 1.22.1. EDIT: such a profile should prob include special cases, but maybe can ignore for now as we'll need to rework that a bit soon.

RE stubs: let's wait on the RST conversion first.

This was referenced Jan 19, 2022
@honno honno closed this as completed in #83 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High-priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants