Skip to content

Streamline CI workflows with --ci option #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Conversation

honno
Copy link
Member

@honno honno commented Jan 19, 2022

This PR helps us for #49 by introducing an option --ci. The idea of this option is to skip redundant tests for a CI scenario, i.e. signatures and type promotion which (should) be covered by the primary tests, and meta tests.

This makes the suite:

  • Faster to run
  • Clearer error situation i.e. no redundant signatures/type promotion errors
  • Much much easier to xfail in a workflow i.e. no redundant type promotion cases

This PR is ready, but actually using --ci should wait until:

honno added 3 commits January 19, 2022 17:28
Black's a productivity boost for me and I'm going to be doing a lot more work here
Redundant if the default behaviour is to only run them if they exist.
@honno honno requested a review from asmeurer January 19, 2022 17:34
@honno honno merged commit a313c3d into data-apis:master Jan 20, 2022
@honno honno deleted the ci-profile branch January 20, 2022 08:48
@honno honno mentioned this pull request Jan 21, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant