Adds dev container and docs #1499
Conversation
|
Nice, I like this. |
m
Outdated
| container_id=$(docker container inspect --format="{{.Id}}" $container_name 2>/dev/null) | ||
|
|
||
| if [ $? -eq "0" ]; then | ||
| echo "--- Killing $container_name" |
There was a problem hiding this comment.
To kill an existing instance of the dev container. much better than having to exec bash back into the container and kill all the watch processes
There was a problem hiding this comment.
Shouldn't the watch process be running in the foreground? Then u can just ctrl+c.
There was a problem hiding this comment.
Not if you get detached from the container, which happens to me all the time. When my ssh loses connection for example.
There was a problem hiding this comment.
If you get detached, the container should exit. You'd want to pass in -it for that to work.
m
Outdated
| fi | ||
| set -e | ||
|
|
||
| echo "--- Spawning $container_name" |
There was a problem hiding this comment.
if the container is already running, we should just reuse it.
There was a problem hiding this comment.
Actually I guess that wouldn't be very useful since you can just use the code-server terminal.
There was a problem hiding this comment.
Having to use the code-server terminal would not be optimal though considering it's constantly reloading, losing its history, etc.
cmoog
force-pushed
the
dev-container
branch
3 times, most recently
from
bb95f7a to
43b7d98
Compare
|
Anything preventing this from merging? @nhooyr |
ci/dev-image/exec.sh
Outdated
| echo "--- Spawning $container_name" | ||
| container_id=$(docker run \ | ||
| -it \ | ||
| --privileged \ |
There was a problem hiding this comment.
why does it need to be privileged?
There was a problem hiding this comment.
I think I was considering vms when I added that. But you're right– not needed for now.
| @@ -0,0 +1,46 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Let's add a comment explaining what the script does.
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| # exec.sh opens an interactive bash session inside of a docker container | |||
| # for improved isolation during development | |||
There was a problem hiding this comment.
Could you elaborate that it reuses the container if it exists? And starts it if stopped.
Closes #1498