-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Adds dev container and docs #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9c0d5f6
Adds dev container and docs
cmoog 28ea763
In dev-image dir
cmoog a1e8523
Use existing container if available
cmoog 0c22227
Adds host flag to docs
cmoog c78878d
Review changes
cmoog 37a5d27
Adds documentation
cmoog d763a3c
fmt
cmoog 8a6ab30
Comment
cmoog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
FROM node:12 | ||
|
||
RUN apt-get update && apt-get install -y \ | ||
curl \ | ||
iproute2 \ | ||
vim \ | ||
iptables \ | ||
net-tools \ | ||
libsecret-1-dev \ | ||
libx11-dev \ | ||
libxkbfile-dev | ||
|
||
CMD ["/bin/bash"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
cd "$(dirname "$0")" | ||
|
||
# Ensure submodules are cloned and up to date. | ||
git submodule update --init | ||
|
||
container_name=code-server-dev | ||
|
||
enter() { | ||
echo "--- Entering $container_name" | ||
docker exec -it $container_id /bin/bash | ||
} | ||
|
||
run() { | ||
echo "--- Spawning $container_name" | ||
container_id=$(docker run \ | ||
-it \ | ||
--privileged \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why does it need to be privileged? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I was considering vms when I added that. But you're right– not needed for now. |
||
--name $container_name \ | ||
"-v=$PWD:/code-server" \ | ||
"-w=/code-server" \ | ||
"-p=8080:8080" \ | ||
cmoog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$([[ -t 0 ]] && echo -it || true) \ | ||
-d \ | ||
cmoog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$container_name) | ||
} | ||
|
||
build() { | ||
echo "--- Building $container_name" | ||
cd ../../ && docker build -t $container_name -f ./ci/dev-image/Dockerfile . > /dev/null | ||
cmoog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
set +e | ||
cmoog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
container_id=$(docker container inspect --format="{{.Id}}" $container_name 2> /dev/null) | ||
|
||
if [ $? -eq "0" ]; then | ||
set -e | ||
echo "-- Starting container" | ||
docker start $container_id > /dev/null | ||
|
||
enter | ||
exit 0 | ||
fi | ||
|
||
set -e | ||
build | ||
run | ||
enter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment explaining what the script does.