refactor: remove debian10/Dockerfile and update CONTRIBUTING #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jawnsy
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
I like having docker images to make development environments reproducible/easier to set up for new contributors, though an unmaintained image is worse than not having one, so this makes sense to me 😄 I think for the future we should revisit this, maybe we could make an image to do code-server development inside code-server, and also a variant for code-server development inside coder.
Closed
|
Love that idea! Noted for future in #2818 :D |
|
Uh oh - we still use the debian10 image in our release workflow, and our custom centos7 image is actually unused; I'll work on removing the dependency on the debian10 image in our workflow before we make a release 😅 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed
debian10/Dockerfilewhich was introduced orignally by moog in #1499 for Docker development.It also updates the
CONTRIBUTING.mdfile with global module/packages required for developing code-server.Originally discussed here noting that we no longer use or need to maintain this.
#3077 (review)