Skip to content

Adds dev container and docs #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2020
Merged

Adds dev container and docs #1499

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9c0d5f6
Adds dev container and docs
cmoog Apr 6, 2020
28ea763
In dev-image dir
cmoog Apr 7, 2020
a1e8523
Use existing container if available
cmoog Apr 7, 2020
0c22227
Adds host flag to docs
cmoog Apr 14, 2020
c78878d
Review changes
cmoog Apr 14, 2020
37a5d27
Adds documentation
cmoog Apr 14, 2020
d763a3c
fmt
cmoog Apr 14, 2020
8a6ab30
Comment
cmoog Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/dev-image/exec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment explaining what the script does.

# exec.sh opens an interactive bash session inside of a docker container
# for improved isolation during development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate that it reuses the container if it exists? And starts it if stopped.


set -euo pipefail
cd "$(dirname "$0")"
Expand Down