Skip to content

Restructure #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 96 commits into from
Mar 3, 2020
Merged

Restructure #1338

merged 96 commits into from
Mar 3, 2020

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Feb 4, 2020 •
edited
Loading

  • Detangle code-server and vscode.
  • Provide a message when trying to load vscode and it hasn't finished compiling yet (for development). Otherwise it can look like the build just failed.
  • Command-line parser.
  • Fix all the absolute paths so it works behind a base path again. This is now achieved by using relative paths everywhere but note that because of this redirecting from HTTP to HTTPS won't work correctly behind a base path so use a reverse proxy for that. This should remove the confusion behind the base path option since it no longer exists.
  • Auto-updates.
  • Pass through to VS Code CLI when necessary.

Fixes #1302
Fixes #1233
Fixes #1303
Fixes #1298
Fixes #1035
Fixes #208
Fixes #1014
Fixes #1002
Fixes #1333
Fixes #1304
Fixes #1383
Fixes #1380

@code-asher code-asher force-pushed the restructure branch 4 times, most recently from a109ffd to bb30510 Compare February 4, 2020 21:37
sr229
sr229 suggested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

@nhooyr nhooyr mentioned this pull request Feb 5, 2020
Closed
@nhooyr nhooyr mentioned this pull request Feb 12, 2020
Merged
@code-asher
Update VS Code to 1.42.0
ac4f2b8
@code-asher
Fix duplicate files opening with folder parameter
cc79edb 
Reworked from d574012 to fit in the
new structure.
@code-asher
Fix base path
bf1be16 
Now it should work whether you have a trailing slash or not.
@code-asher
Add spacing between items
0e37201 
Also fix padding not being respected when blocks exceed container
height.
@nhooyr
Copy link
Contributor

nhooyr commented Feb 27, 2020

We should still have an example gif @kylecarbs

@kylecarbs
Copy link
Member

@nhooyr yup. Gunna add one

@kylecarbs kylecarbs mentioned this pull request Mar 2, 2020
Closed
This was referenced Mar 2, 2020
Closed
Closed
code-asher and others added 8 commits March 2, 2020 11:52
@code-asher
Add recents section
c146457
@code-asher
Move VS Code to the root
069c523
@code-asher
Integrate update notifications into VS Code
ccd01c4
@code-asher
Add example gif
79b4c64
@code-asher
Handle unexpected string errors
ecac0dd 
Looks like sometimes VS Code throws strings. For example if ifconfig is
missing.
@code-asher
Fix worker require paths when behind proxy
77af2a5
@code-asher
Fix mime type for compressed client-side extensions
e0e019f 
In Firefox using the gzip mime type will (probably correctly) cause it
not to decompress while in Chromium it still will (incorrectly).
@kylecarbs
Update favicon
c544509
@nhooyr
Copy link
Contributor

nhooyr commented Mar 3, 2020

🚀

@code-asher code-asher merged commit 2c4ca14 into master Mar 3, 2020
@code-asher code-asher deleted the restructure branch March 3, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr left review comments

@kylecarbs kylecarbs kylecarbs requested changes

@sr229 sr229 sr229 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@code-asher @nhooyr @kylecarbs @sr229