Skip to content

PWA installability: service-worker not found #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
diegosucaria opened this issue Mar 2, 2020 · 1 comment · Fixed by #1338
Closed

PWA installability: service-worker not found #1383

diegosucaria opened this issue Mar 2, 2020 · 1 comment · Fixed by #1338
Labels
bug Something isn't working

Comments

@diegosucaria
Copy link

Hi!

I'm trying to get this installed as a PWA. I have nginx reverse proxy set. a valid SSL cert. it is serving at https://subdomain.domain.com

I'm also running code-server with valid cert and cert-key paths

Nginx reverse proxy is set to https://127.0.0.1:8080

Everything works fine, except, I can't install the PWA:

image

Service worker seems to be there:
image

Any ideas?? thanks!
@diegosucaria diegosucaria added the bug Something isn't working label Mar 2, 2020
@kylecarbs
Copy link
Member

Fixed in the latest refactor coming soon with v3.

PR here: #1338

I'll post once we have the fix in a public release!

@code-asher code-asher mentioned this issue Mar 3, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure coder/code-server
2 participants
@diegosucaria @kylecarbs