scripts/build: ditch -vsc suffix #1310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would fix some automation systems since keeping the vsc suffix with our new tag deployment system breaks some of the CIs most people use.
This is to add some sort of seperation between the version and the name of the binary.
code-asher
reviewed
Jan 28, 2020
scripts/build.ts
Outdated
| @@ -231,7 +231,7 @@ class Builder { | |||
|
|
|||
| const [productJson, packageJson] = await Promise.all([ | |||
| merge("product", { commit, date }), | |||
| merge("package", { codeServerVersion: `${codeServerVersion}-vsc${vscodeVersion}` }), | |||
| merge("package", { codeServerVersion: codeServerVersion }), | |||
There was a problem hiding this comment.
Not a big deal but this could be { codeServerVersion }.
|
Also I think we should add a line to |
Point me to the right direction @code-asher, I don't think I know where. |
added 2 commits
January 29, 2020 22:35
Signed-off-by: Ayane Satomi <[email protected]>
also added a sanity check for daily version print Signed-off-by: Ayane Satomi <[email protected]>
|
Just a little note I can't push to the repository at the moment, but I have the changes ready to merge. |
|
@code-asher says he already merged into #1338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix some automation systems since keeping the vsc suffix with our new tag deployment system breaks some of the CIs most people use.
This should reproduce quite predictable builds like we did previously.
This compliments GH-1303.