Skip to content

Git authentication prompt not showing in editor view #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elgandoz opened this issue Sep 19, 2019 · 2 comments · Fixed by #1338
Closed

Git authentication prompt not showing in editor view #1002

elgandoz opened this issue Sep 19, 2019 · 2 comments · Fixed by #1338
Assignees
@code-asher
Labels
bug Something isn't working

Comments

@elgandoz
Copy link

elgandoz commented Sep 19, 2019 •
edited
Loading

  • code-server version: 2.1523-vsc1.38.1
  • OS Version: CentOS / RHEL 7.7

Description

When the user is unauthenticated in a repo and perform a pull/push via the SCM button, the user/password prompt appears in the (remote) terminal which launched code-server.
In the current VS Code the prompts appear as modal in the client.

Steps to Reproduce

  1. Open a folder in a git repository, where you don't have write permission
  2. Commit anything
  3. Hit the push/pull button

Screenshots

code-server 2.1523-vsc1.38.1
Screen Shot 2019-09-19 at 23 56 46

vs code 1.38.1
Screen Shot 2019-09-20 at 00 08 59
@elgandoz elgandoz added the bug Something isn't working label Sep 19, 2019
@elgandoz elgandoz changed the title Git authentication prompt not showing Git authentication prompt not showing in editor view Sep 19, 2019
@sr229 sr229 added the v2 label Sep 19, 2019
@sr229
Copy link
Contributor

sr229 commented Sep 19, 2019

@elgandoz I agree this seems to be out of place, for now your workaround would be using the CLI.

@nhooyr nhooyr removed the v2 label Jan 27, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Feb 3, 2020

Confirmed.

@code-asher code-asher mentioned this issue Mar 3, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure coder/code-server
4 participants
@elgandoz @nhooyr @sr229 @code-asher