Add frosting to CI and sync with main
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with my main
Km test assign arg list
Issue #22 of uniting lag and ahead functions.
Documented changes.
Renamed a subclass.
Km issue 22 fix
Merge branch 'main' of https://github.com/kenmawer/epipredict into km-issue_22_unite # Conflicts: # R/epi_lag.R
Km issue 22 unite
Fixed butchered NAMESPACE.
Deleted placeholder I made when creating file.
Km pr 34 rectify tests
Km pr 34 rectify tests
Km pr 34 rectify tests
add codeowners
|
@brookslogan CI is getting this error (got it locally too). Any ideas? Error: Error: processing vignette 'knn-forecasts.Rmd' failed with diagnostics:
C stack usage 15945684 is too close to the limit |
dshemetov
force-pushed
the
ds/frosting-ci
branch
from
39039ea to
18cc390
Compare
brookslogan
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Looks good to me, aside from the cleanliness of the as_tibble.epi_df approach which will be addressed in a separate issue. [The original approach was just minimally edited to avoid infinite recursion in the knn vignette when epiprocess and epipredict are both loaded. It is still probably asking for some unintended behavior down the line.]
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test, but should really be all the changes we need for #47 .